Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 904823002: webrtc: Fixes WebRtcBrowserTest to use DOM attributes correctly. (Closed)

Created:
5 years, 10 months ago by Yuki
Modified:
5 years, 10 months ago
CC:
chromium-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webrtc: Fixes WebRtcBrowserTest to use DOM attributes correctly. WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs is assuming that DOM attributes are own properties on a JS obejct, which is not correct. Blink (binding) team is working to move DOM attributes from own properties to properties on prototype chains, and then this test will break. This CL fixes the test so that it stringifies not only own properties but also attributes on prototype chains. BUG=43394 Committed: https://crrev.com/e27865b72eab201b557a60b88bb648e3f8b0843f Cr-Commit-Position: refs/heads/master@{#315198}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed a review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M chrome/test/data/webrtc/peerconnection.js View 1 5 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yuki
Patrik, could you review this CL?
5 years, 10 months ago (2015-02-06 07:20:25 UTC) #2
haraken
non-owner LGTM
5 years, 10 months ago (2015-02-06 07:53:18 UTC) #3
phoglund_chromium
lgtm https://codereview.chromium.org/904823002/diff/1/chrome/test/data/webrtc/peerconnection.js File chrome/test/data/webrtc/peerconnection.js (right): https://codereview.chromium.org/904823002/diff/1/chrome/test/data/webrtc/peerconnection.js#newcode294 chrome/test/data/webrtc/peerconnection.js:294: return src; Nit: indent 2
5 years, 10 months ago (2015-02-06 09:46:30 UTC) #4
Yuki
https://codereview.chromium.org/904823002/diff/1/chrome/test/data/webrtc/peerconnection.js File chrome/test/data/webrtc/peerconnection.js (right): https://codereview.chromium.org/904823002/diff/1/chrome/test/data/webrtc/peerconnection.js#newcode294 chrome/test/data/webrtc/peerconnection.js:294: return src; On 2015/02/06 09:46:29, phoglund wrote: > Nit: ...
5 years, 10 months ago (2015-02-07 11:25:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904823002/20001
5 years, 10 months ago (2015-02-07 11:26:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-07 12:33:45 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 12:35:05 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e27865b72eab201b557a60b88bb648e3f8b0843f
Cr-Commit-Position: refs/heads/master@{#315198}

Powered by Google App Engine
This is Rietveld 408576698