Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/IceELFSection.h

Issue 904783002: Subzero: Convert a few getName() methods to return a const string ref. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceELFObjectWriter.cpp ('k') | src/IceOperand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceELFSection.h
diff --git a/src/IceELFSection.h b/src/IceELFSection.h
index 24ec5619d8a307e2e5d4ab305886484b3d2ba1c5..535d1530b06f44f323151417d8aa6a16c3476f50 100644
--- a/src/IceELFSection.h
+++ b/src/IceELFSection.h
@@ -66,7 +66,7 @@ public:
void setNameStrIndex(Elf64_Word sh_name) { Header.sh_name = sh_name; }
- IceString getName() const { return Name; }
+ const IceString &getName() const { return Name; }
void setLinkNum(Elf64_Word sh_link) { Header.sh_link = sh_link; }
@@ -84,7 +84,7 @@ protected:
// Name of the section in convenient string form (instead of a index
// into the Section Header String Table, which is not known till later).
- IceString Name;
+ const IceString Name;
// The fields of the header. May only be partially initialized, but should
// be fully initialized before writing.
« no previous file with comments | « src/IceELFObjectWriter.cpp ('k') | src/IceOperand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698