Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: runtime/vm/object.h

Issue 904763003: Redesign inlining interval computation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 43603)
+++ runtime/vm/object.h (working copy)
@@ -4043,9 +4043,9 @@
enum InlinedIntervalEntries {
kInlIntStart = 0,
- kInlIntEnd = 1,
- kInlIntFunction = 2,
- kInlIntNumEntries = 3
+ kInlIntInliningId = 1,
+ kInlIntCallerId = 2,
+ kInlIntNumEntries = 3,
};
RawArray* inlined_intervals() const {
@@ -4053,6 +4053,11 @@
}
void set_inlined_intervals(const Array& value) const;
+ RawArray* inlined_id_to_function() const {
+ return raw_ptr()->inlined_id_to_function_;
+ }
+ void set_inlined_id_to_function(const Array& value) const;
+
void GetInlinedFunctionsAt(
intptr_t offset, GrowableArray<Function*>* fs) const;
@@ -4233,6 +4238,9 @@
*PointerOffsetAddrAt(index) = offset_in_instructions;
}
+ // Currently slow, as it searches linearly through inlined_intervals().
+ intptr_t GetCallerId(intptr_t inlined_id) const;
+
intptr_t BinarySearchInSCallTable(uword pc) const;
static RawCode* LookupCodeInIsolate(Isolate* isolate, uword pc);

Powered by Google App Engine
This is Rietveld 408576698