Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: runtime/vm/disassembler.cc

Issue 904763003: Redesign inlining interval computation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler.cc
===================================================================
--- runtime/vm/disassembler.cc (revision 43621)
+++ runtime/vm/disassembler.cc (working copy)
@@ -141,15 +141,19 @@
if (old_comment_finger != comment_finger) {
// Comment emitted, emit inlining information.
code.GetInlinedFunctionsAt(offset, &inlined_functions);
- // Skip top scope function printing.
- for (intptr_t i = 1; i < inlined_functions.length(); i++) {
- if (i == 1) {
- formatter->Print(" ;; Inlined ");
+ // Skip top scope function printing (last entry in 'inlined_functions').
+ bool first = true;
+ for (intptr_t i = inlined_functions.length() - 2; i >= 0; i--) {
+ const char* name = inlined_functions[i]->ToQualifiedCString();
+ if (first) {
+ formatter->Print(" ;; Inlined [%s", name);
+ first = false;
+ } else {
+ formatter->Print(" -> %s", name);
}
- formatter->Print("-> %s ", inlined_functions[i]->ToQualifiedCString());
}
- if (inlined_functions.length() > 1) {
- formatter->Print("\n");
+ if (!first) {
+ formatter->Print("]\n");
}
}
int instruction_length;
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698