Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java

Issue 904733003: Rework requests in execution domain (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Clean-up Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java
index 1ce0176345de7050e9f58521297f9c11be9d5329..cbb4e449f408d3344e1fc36622bccb199fb09be2 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java
@@ -345,7 +345,8 @@ public interface AnalysisServer {
* created will persist until execution.deleteContext is used to delete it. Clients, therefore, are
* responsible for managing the lifetime of execution contexts.
*
- * @param contextRoot The path of the Dart or HTML file that will be launched.
+ * @param contextRoot The path of the Dart or HTML file that will be launched, or the path of the
+ * directory containing the file.
*/
public void execution_createContext(String contextRoot, CreateContextConsumer consumer);
@@ -365,18 +366,19 @@ public interface AnalysisServer {
* Map a URI from the execution context to the file that it corresponds to, or map a file to the
* URI that it corresponds to in the execution context.
*
- * Exactly one of the file and uri fields must be provided.
+ * Exactly one of the file and uri fields must be provided. If both fields are provided, then an
+ * error of type INVALID_PARAMETER will be generated. Similarly, if neither field is provided, then
+ * an error of type INVALID_PARAMETER will be generated.
*
* If the file field is provided and the value is not the path of a file (either the file does not
* exist or the path references something other than a file), then an error of type
- * MAP_URI_INVALID_FILE will be generated.
+ * INVALID_PARAMETER will be generated.
*
* If the uri field is provided and the value is not a valid URI or if the URI references something
* that is not a file (either a file that does not exist or something other than a file), then an
- * error of type MAP_URI_INVALID_URI will be generated.
+ * error of type INVALID_PARAMETER will be generated.
*
- * If the contextRoot used to create the execution context is not a file (either the file does not
- * exist or the path references something other than a file), then an error of type
+ * If the contextRoot used to create the execution context does not exist, then an error of type
* INVALID_EXECUTION_CONTEXT will be generated.
*
* @param id The identifier of the execution context in which the URI is to be mapped.

Powered by Google App Engine
This is Rietveld 408576698