Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: ui/events/ozone/evdev/input_device_factory_evdev.cc

Issue 904733002: Remove useless InputDevice::name field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/ozone/evdev/input_device_factory_evdev.cc
diff --git a/ui/events/ozone/evdev/input_device_factory_evdev.cc b/ui/events/ozone/evdev/input_device_factory_evdev.cc
index daaaa267bb795c1e4b43ac10b33bf664455ae3e0..fe566aba6fbc5cd2c8df814912502a179f9ba9a7 100644
--- a/ui/events/ozone/evdev/input_device_factory_evdev.cc
+++ b/ui/events/ozone/evdev/input_device_factory_evdev.cc
@@ -440,9 +440,9 @@ void InputDeviceFactoryEvdev::NotifyTouchscreensUpdated() {
// TODO(spang): Extract the number of touch-points supported by the
// device.
const int touch_points = 11;
- touchscreens.push_back(TouchscreenDevice(
- it->second->id(), it->second->type(), std::string() /* Device name */,
- it->second->GetTouchscreenSize(), touch_points));
+ touchscreens.push_back(
+ TouchscreenDevice(it->second->id(), it->second->type(),
+ it->second->GetTouchscreenSize(), touch_points));
}
}
@@ -453,8 +453,7 @@ void InputDeviceFactoryEvdev::NotifyKeyboardsUpdated() {
std::vector<KeyboardDevice> keyboards;
for (auto it = converters_.begin(); it != converters_.end(); ++it) {
if (it->second->HasKeyboard()) {
- keyboards.push_back(KeyboardDevice(it->second->id(), it->second->type(),
- std::string() /* Device name */));
+ keyboards.push_back(KeyboardDevice(it->second->id(), it->second->type()));
}
}
@@ -464,10 +463,8 @@ void InputDeviceFactoryEvdev::NotifyKeyboardsUpdated() {
void InputDeviceFactoryEvdev::NotifyMouseDevicesUpdated() {
std::vector<InputDevice> mice;
for (auto it = converters_.begin(); it != converters_.end(); ++it) {
- if (it->second->HasMouse()) {
- mice.push_back(InputDevice(it->second->id(), it->second->type(),
- std::string() /* Device name */));
- }
+ if (it->second->HasMouse())
+ mice.push_back(InputDevice(it->second->id(), it->second->type()));
}
dispatcher_->DispatchMouseDevicesUpdated(mice);
@@ -476,10 +473,8 @@ void InputDeviceFactoryEvdev::NotifyMouseDevicesUpdated() {
void InputDeviceFactoryEvdev::NotifyTouchpadDevicesUpdated() {
std::vector<InputDevice> touchpads;
for (auto it = converters_.begin(); it != converters_.end(); ++it) {
- if (it->second->HasTouchpad()) {
- touchpads.push_back(InputDevice(it->second->id(), it->second->type(),
- std::string() /* Device name */));
- }
+ if (it->second->HasTouchpad())
+ touchpads.push_back(InputDevice(it->second->id(), it->second->type()));
}
dispatcher_->DispatchTouchpadDevicesUpdated(touchpads);
« no previous file with comments | « ui/events/devices/x11/device_data_manager_x11_unittest.cc ('k') | ui/events/platform/x11/x11_hotplug_event_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698