Remove useless InputDevice::name field

Remove useless InputDevice::name field

BUG=None
TEST=None
R=sadrul
TBR=oshima

Committed: https://crrev.com/6f83c7da840ca08ba1f292c6c8aa9a18dc2427a1
Cr-Commit-Position: refs/heads/master@{#315072}

[pkotwicz, 2015-02-05 20:16:57]

pkotwicz@chromium.org changed reviewers:
+ rsadam@chromium.org

[pkotwicz, 2015-02-05 20:16:58]

Raheem, can you please take a look?

Was there a reason that the InputDevice::name field was added that I am not
getting? The only thing that I can think of is in
DeviceDataManager::OnKeyboardDevicesUpdated() as part of the std::equal() call,
but it should not matter because we should be getting a separate call to
DeviceDataManager::OnKeyboardDevicesUpdated() when a device is removed and a
separate call when a device is added even if the remove and add happens very
very quickly

[rsadam, 2015-02-05 20:21:02]

On 2015/02/05 20:16:58, pkotwicz wrote:
> Raheem, can you please take a look?
> 
> Was there a reason that the InputDevice::name field was added that I am not
> getting? The only thing that I can think of is in
> DeviceDataManager::OnKeyboardDevicesUpdated() as part of the std::equal()
call,
> but it should not matter because we should be getting a separate call to
> DeviceDataManager::OnKeyboardDevicesUpdated() when a device is removed and a
> separate call when a device is added even if the remove and add happens very
> very quickly

We use the name to blacklist certain devices:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/platform...

[pkotwicz, 2015-02-05 20:24:02]

We do use the device name there. However, we do not use InputDevice::name (i.e.
my CL compiles)

[rsadam, 2015-02-05 20:27:53]

On 2015/02/05 20:24:02, pkotwicz wrote:
> We do use the device name there. However, we do not use InputDevice::name
(i.e.
> my CL compiles)

Oh I see. The reason I included that was that legacy touchscreen code used the
name. I believe that was all removed though. +dnicoara can you confirm?

[rsadam, 2015-02-05 20:28:04]

rsadam@chromium.org changed reviewers:
+ dnicoara@chromium.org

[dnicoara, 2015-02-05 20:39:56]

On 2015/02/05 20:27:53, rsadam wrote:
> On 2015/02/05 20:24:02, pkotwicz wrote:
> > We do use the device name there. However, we do not use InputDevice::name
> (i.e.
> > my CL compiles)
> 
> Oh I see. The reason I included that was that legacy touchscreen code used the
> name. I believe that was all removed though. +dnicoara can you confirm?

The name was included in https://codereview.chromium.org/618283003 due to its
usage in X11 keyboard code in
ui/events/platform/x11/x11_hotplug_event_handler.cc Sadrul asked to have it in
InputDevice in comment #10 since it could be a shared field.

[pkotwicz, 2015-02-06 02:37:56]

pkotwicz@chromium.org changed reviewers:
+ sadrul@chromium.org

[pkotwicz, 2015-02-06 02:37:56]

+sadrul

[sadrul, 2015-02-06 02:41:55]

We shouldn't have it if we are not using it. LGTM

[dnicoara, 2015-02-06 02:44:59]

On 2015/02/06 02:41:55, sadrul wrote:
> We shouldn't have it if we are not using it. LGTM

It's still being used on X11, though only in the keyboard code.

[dnicoara, 2015-02-06 02:54:41]

On 2015/02/06 02:44:59, dnicoara wrote:
> On 2015/02/06 02:41:55, sadrul wrote:
> > We shouldn't have it if we are not using it. LGTM
> 
> It's still being used on X11, though only in the keyboard code.

Oh, I guess the code using it got removed?

[pkotwicz, 2015-02-06 03:34:38]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-02-06 03:35:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/904733002/1

[commit-bot: I haz the power, 2015-02-06 03:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 03:52:22]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2015-02-06 16:05:54]

New patchsets have been uploaded after l-g-t-m from sadrul@chromium.org

[pkotwicz, 2015-02-06 16:07:22]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-02-06 16:07:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/904733002/20001

[commit-bot: I haz the power, 2015-02-06 16:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 16:14:16]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkotwicz, 2015-02-06 18:22:20]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-02-06 18:23:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/904733002/20001

[commit-bot: I haz the power, 2015-02-06 18:27:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-06 18:28:22]

Patchset 2 (id:??) landed as
https://crrev.com/6f83c7da840ca08ba1f292c6c8aa9a18dc2427a1
Cr-Commit-Position: refs/heads/master@{#315072}