Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 904683002: Disable PopupBlockerBrowserTest.CtrlEnterKey (Closed)

Created:
5 years, 10 months ago by Noel Gordon
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, apavlov, dcheng, pdr., myid.m.shin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable PopupBlockerBrowserTest.CtrlEnterKey Failing due to Blink r189541 which can't just be reverted. Disable this test while investigating the Blink r198541 failure. Landing to progress the Blink roll. TBR=jochen@chromum.org NOTREECHECK=true NOTRY=true BUG=455691 Committed: https://crrev.com/a4bb80f9ae7957f489231c40f746d5234083fb10 Cr-Commit-Position: refs/heads/master@{#314803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Noel Gordon
5 years, 10 months ago (2015-02-05 13:28:50 UTC) #2
apavlov
lgtm
5 years, 10 months ago (2015-02-05 13:29:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904683002/1
5 years, 10 months ago (2015-02-05 13:54:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904683002/1
5 years, 10 months ago (2015-02-05 13:56:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904683002/1
5 years, 10 months ago (2015-02-05 14:00:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 14:02:03 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 14:03:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4bb80f9ae7957f489231c40f746d5234083fb10
Cr-Commit-Position: refs/heads/master@{#314803}

Powered by Google App Engine
This is Rietveld 408576698