Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 904643002: Clean up unittests mocking IsOffTheRecord on PasswordManagerDriver (Closed)

Created:
5 years, 10 months ago by qi1988.yang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up unittests mocking IsOffTheRecord on PasswordManagerDriver Originally, IsOffTheRecord used to be a method of PasswordManagerDriver, but was moved to PasswordManagerClient. Clear up the mocks of "EXPECT_CALL(*(client()->mock_driver()), IsOffTheRecord()).WillRepeatedly(Return(false));" BUG=440426 Committed: https://crrev.com/e9d0844619b73f6b23061d817b6c8bccf70db139 Cr-Commit-Position: refs/heads/master@{#315507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 13 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
qi1988.yang
5 years, 10 months ago (2015-02-05 10:00:39 UTC) #2
vabr (Chromium)
LGTM, thanks! (For the record, following the checklist at http://www.chromium.org/developers/contributing-code/external-contributor-checklist I verified that in addition ...
5 years, 10 months ago (2015-02-05 10:09:57 UTC) #3
qi1988.yang
Could you take a look at the patch? Thanks,very much!
5 years, 10 months ago (2015-02-09 01:55:56 UTC) #5
Garrett Casto
lgtm
5 years, 10 months ago (2015-02-09 05:19:38 UTC) #6
vabr (Chromium)
By the way, qi1988.yang, you don't need that many reviewers. You need to get at ...
5 years, 10 months ago (2015-02-09 08:50:49 UTC) #7
qi1988.yang
-Ilya Sherman, -Mike Mammarella, -albertb from reviewer list
5 years, 10 months ago (2015-02-09 09:00:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904643002/1
5 years, 10 months ago (2015-02-09 09:48:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) ios_dbg_simulator on ...
5 years, 10 months ago (2015-02-09 11:49:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904643002/1
5 years, 10 months ago (2015-02-10 05:56:48 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 05:57:15 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 05:57:59 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9d0844619b73f6b23061d817b6c8bccf70db139
Cr-Commit-Position: refs/heads/master@{#315507}

Powered by Google App Engine
This is Rietveld 408576698