Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 904633003: Just visit young array buffers during scavenge. (Closed)

Created:
5 years, 10 months ago by Hannes Payer (out of office)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Just visit young array buffers during scavenge. Additionally keep the views in new space in a separate global list and move them to the corresponding array buffers when they get promoted. This reduces young generation garbage collections when many array buffers are allocated. BUG= Committed: https://crrev.com/bd61a85fafd6461a40dc1e20252fd843f148e837 Cr-Commit-Position: refs/heads/master@{#26605}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -55 lines) Patch
M src/factory.cc View 1 2 3 4 5 1 chunk +8 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 5 chunks +26 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 6 chunks +70 lines, -9 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/objects-visiting.h View 1 6 7 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/objects-visiting.cc View 1 2 3 4 6 7 5 chunks +25 lines, -15 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 1 chunk +9 lines, -2 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 2 3 5 chunks +46 lines, -6 lines 0 comments Download
M src/serialize.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 1 2 3 6 chunks +44 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Hannes Payer (out of office)
PTAL. https://codereview.chromium.org/904633003/diff/40001/src/runtime/runtime-typedarray.cc File src/runtime/runtime-typedarray.cc (right): https://codereview.chromium.org/904633003/diff/40001/src/runtime/runtime-typedarray.cc#newcode107 src/runtime/runtime-typedarray.cc:107: // that belong to the neutered array buffer. ...
5 years, 10 months ago (2015-02-06 12:21:11 UTC) #2
ulan
> We could do this in one pass with a specialized Visitor. +1, that seems ...
5 years, 10 months ago (2015-02-06 14:36:46 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/904633003/diff/80001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/904633003/diff/80001/src/heap/heap.cc#newcode1754 src/heap/heap.cc:1754: } On 2015/02/06 14:36:46, ulan wrote: > Update new_array_buffer_views_list ...
5 years, 10 months ago (2015-02-10 14:41:31 UTC) #4
ulan
lgtm
5 years, 10 months ago (2015-02-11 16:38:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904633003/140001
5 years, 10 months ago (2015-02-12 09:14:29 UTC) #7
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 10 months ago (2015-02-12 10:00:34 UTC) #8
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/bd61a85fafd6461a40dc1e20252fd843f148e837 Cr-Commit-Position: refs/heads/master@{#26605}
5 years, 10 months ago (2015-02-12 10:00:59 UTC) #9
Michael Achenbach
5 years, 10 months ago (2015-02-16 07:22:09 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/929933002/ by machenbach@chromium.org.

The reason for reverting is: Introduces crashes..

Powered by Google App Engine
This is Rietveld 408576698