Autofill: First step toward CVC unmask prompt dialog on OSX.

chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc

Index: chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc
diff --git a/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc b/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b6bc529baae74efc0abd8fbb427390351d27cc81
--- /dev/null
+++ b/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc
@@ -0,0 +1,119 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/guid.h"
+#include "base/message_loop/message_loop.h"
+#include "chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.h"
+#include "chrome/browser/ui/autofill/card_unmask_prompt_view_tester.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "components/autofill/core/browser/card_unmask_delegate.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/test_utils.h"
+
+namespace autofill {
+
+namespace {
+
+class TestCardUnmaskDelegate : public CardUnmaskDelegate {
+ public:
+  TestCardUnmaskDelegate() : weak_factory_(this) {}
+
+  virtual ~TestCardUnmaskDelegate() {}

[bondd, 2015/02/24 00:24:33]

scoped_ptr complains if destructor is non-virtual.

+
+  // CardUnmaskDelegate implementation.
+  void OnUnmaskResponse(const UnmaskResponse& response) override {}
+  void OnUnmaskPromptClosed() override {}
+
+  base::WeakPtr<TestCardUnmaskDelegate> GetWeakPtr() {
+    return weak_factory_.GetWeakPtr();
+  }
+
+ private:
+  base::WeakPtrFactory<TestCardUnmaskDelegate> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestCardUnmaskDelegate);
+};
+
+class TestCardUnmaskPromptController : public CardUnmaskPromptControllerImpl {
+ public:
+  TestCardUnmaskPromptController(
+      content::WebContents* contents,
+      scoped_refptr<content::MessageLoopRunner> runner)
+      : CardUnmaskPromptControllerImpl(contents),
+        runner_(runner),
+        weak_factory_(this) {}
+
+  // CardUnmaskPromptControllerImpl implementation.
+  void OnDidLoadRiskFingerprint(const std::string& risk_data) override {
+    CardUnmaskPromptControllerImpl::OnDidLoadRiskFingerprint(risk_data);
+
+    // Call Quit() from here rather than from OnUnmaskDialogClosed().
+    // FingerprintDataLoader starts several async tasks that take a while to
+    // complete. If Quit() is called before FingerprintDataLoader is all done
+    // then LeakTracker will detect that some resources have not been freed
+    // and cause the browser test to fail. This is not a real leak though -
+    // normally the async tasks would complete and encounter weak callbacks.
+    runner_->Quit();
+  }
+
+  void RunMessageLoop() { runner_->Run(); }
+
+  scoped_ptr<CardUnmaskPromptViewTester> GetViewTester() {
+    return CardUnmaskPromptViewTester::For(view()).Pass();
+  }
+
+  base::WeakPtr<TestCardUnmaskPromptController> GetWeakPtr() {
+    return weak_factory_.GetWeakPtr();
+  }
+
+ private:
+  scoped_refptr<content::MessageLoopRunner> runner_;
+  base::WeakPtrFactory<TestCardUnmaskPromptController> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestCardUnmaskPromptController);
+};
+
+class CardUnmaskPromptViewBrowserTest : public InProcessBrowserTest {
+ public:
+  CardUnmaskPromptViewBrowserTest() : InProcessBrowserTest() {}
+
+  ~CardUnmaskPromptViewBrowserTest() override {}
+
+  void SetUpOnMainThread() override {
+    runner_ = new content::MessageLoopRunner;
+    controller_.reset(new TestCardUnmaskPromptController(
+        browser()->tab_strip_model()->GetActiveWebContents(), runner_));
+    delegate_.reset(new TestCardUnmaskDelegate());
+  }
+
+  base::WeakPtr<TestCardUnmaskPromptController> controller() {
+    return controller_->GetWeakPtr();
+  }
+
+  base::WeakPtr<TestCardUnmaskDelegate> delegate() {
+    return delegate_->GetWeakPtr();
+  }

[bondd, 2015/02/24 00:24:33]

Made these WeakPtrs to automatically detect if stale pointer is used.

[Evan Stade, 2015/02/24 22:19:22]

not sure I follow, the lifetime of |controller_| and |delegate_| is bound to
|this|. How could delegate() be stale? If delegate_ is null, what does
delegate_->GetWeakPtr() give you?

[bondd, 2015/02/24 23:51:52]

Yep you're right. Fixed.

+
+ private:
+  // This member must outlive the controller.
+  scoped_refptr<content::MessageLoopRunner> runner_;
+
+  scoped_ptr<TestCardUnmaskPromptController> controller_;

[bondd, 2015/02/24 00:24:33]

Comment "The controller owns itself" was wrong; fixed controller_ ownership by
making it a scoped_ptr.

+  scoped_ptr<TestCardUnmaskDelegate> delegate_;
+
+  DISALLOW_COPY_AND_ASSIGN(CardUnmaskPromptViewBrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest, DisplayUI) {
+  CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
+
+  controller()->ShowPrompt(credit_card, delegate());
+  controller()->RunMessageLoop();
+}
+
+}  // namespace
+
+}  // namespace autofill