chrome/browser/ui/autofill/card_unmask_prompt_view.cc - Issue 904613006: Autofill: First step toward CVC unmask prompt dialog on OSX.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/autofill/card_unmask_prompt_view.cc

Issue 904613006: Autofill: First step toward CVC unmask prompt dialog on OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix TODO. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/basictypes.h"	5 #include "base/basictypes.h"

6 #include "chrome/browser/ui/autofill/card_unmask_prompt_view.h"	6 #include "chrome/browser/ui/autofill/card_unmask_prompt_view.h"

7	7

8 namespace autofill {	8 namespace autofill {

9	9

10 #if defined(OS_MACOSX)

11 // static

12 CardUnmaskPromptView* CardUnmaskPromptView::CreateAndShow(

13 CardUnmaskPromptController* controller) {

14 return nullptr;

15 }

16 #endif

17

18 CardUnmaskPromptView::CardUnmaskPromptView() {	10 CardUnmaskPromptView::CardUnmaskPromptView() {

19 }	11 }

20 CardUnmaskPromptView::~CardUnmaskPromptView() {	12 CardUnmaskPromptView::~CardUnmaskPromptView() {
	groby-ooo-7-16 2015/02/06 03:06:18 Why do these two (or the whole .cc file, really) e Why do these two (or the whole .cc file, really) exist? bondd 2015/02/09 19:21:00 @estade: Is it okay with you if I get rid of this Show quoted text On 2015/02/06 03:06:18, groby wrote: > Why do these two (or the whole .cc file, really) exist? @estade: Is it okay with you if I get rid of this .cc file and put empty definitions of these two in the .h file? Evan Stade 2015/02/09 19:30:22 I think presubmit checks might complain with somet Show quoted text On 2015/02/09 19:21:00, bondd wrote: > On 2015/02/06 03:06:18, groby wrote: > > Why do these two (or the whole .cc file, really) exist? > > @estade: Is it okay with you if I get rid of this .cc file and put empty > definitions of these two in the .h file? I think presubmit checks might complain with something like "non-trivial class requires explicit out of line constructor/destructor" or some such. But if not, sure.
21 }	13 }

22	14

23 } // namespace autofill	15 } // namespace autofill

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/card_unmask_prompt_cocoa.h » ('j') | chrome/browser/ui/cocoa/autofill/card_unmask_prompt_cocoa.h » ('J')