Autofill: First step toward CVC unmask prompt dialog on OSX.

chrome/browser/ui/cocoa/autofill/card_unmask_prompt_cocoa_browsertest.mm

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/guid.h"
+#include "base/message_loop/message_loop.h"
+#include "chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.h"
+#include "chrome/browser/ui/browser.h"
+#import "chrome/browser/ui/cocoa/autofill/card_unmask_prompt_bridge.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "components/autofill/core/browser/card_unmask_delegate.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/test_utils.h"
+
+namespace autofill {
+
+namespace {
+
+class TestCardUnmaskPromptController : public CardUnmaskPromptControllerImpl,

[groby-ooo-7-16, 2015/02/12 00:51:55]

Can this be shared with Views tests?

[bondd, 2015/02/12 19:07:22]

Yes I think it can. I was planning to do that as a separate CL. Is that okay by
you?

+                                       public CardUnmaskDelegate {
+ public:
+  TestCardUnmaskPromptController(
+      content::WebContents* contents,
+      scoped_refptr<content::MessageLoopRunner> runner)
+      : CardUnmaskPromptControllerImpl(contents),
+        runner_(runner),
+        weak_factory_(this) {}
+
+  ~TestCardUnmaskPromptController() {}
+
+  // CardUnmaskPromptController implementation.
+  void OnUnmaskDialogClosed() override {
+    DCHECK(runner_);
+    CardUnmaskPromptControllerImpl::OnUnmaskDialogClosed();
+    runner_->Quit();
+  }
+
+  // CardUnmaskDelegate implementation.
+  void OnUnmaskResponse(const base::string16& cvc,
+                        const base::string16& exp_month,
+                        const base::string16& exp_year) override {}
+  void OnUnmaskPromptClosed() override {}
+
+  void RunMessageLoop() {
+    DCHECK(runner_);
+    runner_->Run();
+  }
+
+  base::WeakPtr<TestCardUnmaskPromptController> GetWeakPtr() {
+    return weak_factory_.GetWeakPtr();
+  }
+
+  // Increase visibility for testing.
+  CardUnmaskPromptView* view() {
+    return CardUnmaskPromptControllerImpl::view();
+  }
+
+ private:
+  scoped_refptr<content::MessageLoopRunner> runner_;
+  base::WeakPtrFactory<TestCardUnmaskPromptController> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestCardUnmaskPromptController);
+};
+
+class CardUnmaskPromptCocoaBrowserTest : public InProcessBrowserTest {
+ public:
+  CardUnmaskPromptCocoaBrowserTest() : InProcessBrowserTest() {}
+
+  ~CardUnmaskPromptCocoaBrowserTest() override {}
+
+  void SetUpOnMainThread() override {
+    runner_ = new content::MessageLoopRunner;
+    controller_ = new TestCardUnmaskPromptController(
+        browser()->tab_strip_model()->GetActiveWebContents(), runner_);
+  }
+
+  TestCardUnmaskPromptController* controller() { return controller_; }
+
+ private:
+  // The controller owns itself.
+  TestCardUnmaskPromptController* controller_;
+
+  // This member must outlive the controller.
+  scoped_refptr<content::MessageLoopRunner> runner_;

[groby-ooo-7-16, 2015/02/12 00:51:56]

If it must outlive the controller, it might be better to declare it before
controller_ (deletion happens in reverse declaration order)

I know that currently the test controller also holds a reference, but that's an
implementation detail we shouldn't rely on.

[bondd, 2015/02/12 19:07:22]

Done. Thanks!

+
+  DISALLOW_COPY_AND_ASSIGN(CardUnmaskPromptCocoaBrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(CardUnmaskPromptCocoaBrowserTest, DisplayUI) {
+  CreditCard credit_card(base::GenerateGUID(), "https://www.example.com/");
+
+  controller()->ShowPrompt(credit_card, controller()->GetWeakPtr());
+  controller()->view()->CancelForTesting();
+
+  controller()->RunMessageLoop();
+}
+
+}  // namespace
+
+}  // namespace autofill