Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: sky/engine/core/rendering/RenderObject.h

Issue 904613005: Remove position:relative. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 private:\ 719 private:\
720 unsigned m_##name : 1;\ 720 unsigned m_##name : 1;\
721 public:\ 721 public:\
722 bool name() const { return m_##name; }\ 722 bool name() const { return m_##name; }\
723 void set##Name(bool name) { m_##name = name; }\ 723 void set##Name(bool name) { m_##name = name; }\
724 724
725 class RenderObjectBitfields { 725 class RenderObjectBitfields {
726 // FIXME(sky): Remove this enum and just use EPosition directly. 726 // FIXME(sky): Remove this enum and just use EPosition directly.
727 enum PositionedState { 727 enum PositionedState {
728 IsStaticallyPositioned = 0, 728 IsStaticallyPositioned = 0,
729 IsRelativelyPositioned = 1, 729 IsOutOfFlowPositioned = 1,
730 IsOutOfFlowPositioned = 2,
731 }; 730 };
732 731
733 public: 732 public:
734 RenderObjectBitfields(Node* node) 733 RenderObjectBitfields(Node* node)
735 : m_selfNeedsLayout(false) 734 : m_selfNeedsLayout(false)
736 , m_onlyNeededPositionedMovementLayout(false) 735 , m_onlyNeededPositionedMovementLayout(false)
737 , m_neededLayoutBecauseOfChildren(false) 736 , m_neededLayoutBecauseOfChildren(false)
738 , m_needsPositionedMovementLayout(false) 737 , m_needsPositionedMovementLayout(false)
739 , m_normalChildNeedsLayout(false) 738 , m_normalChildNeedsLayout(false)
740 , m_posChildNeedsLayout(false) 739 , m_posChildNeedsLayout(false)
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
784 ADD_BOOLEAN_BITFIELD(hasTransform, HasTransform); 783 ADD_BOOLEAN_BITFIELD(hasTransform, HasTransform);
785 ADD_BOOLEAN_BITFIELD(hasBoxDecorationBackground, HasBoxDecorationBackgro und); 784 ADD_BOOLEAN_BITFIELD(hasBoxDecorationBackground, HasBoxDecorationBackgro und);
786 785
787 ADD_BOOLEAN_BITFIELD(everHadLayout, EverHadLayout); 786 ADD_BOOLEAN_BITFIELD(everHadLayout, EverHadLayout);
788 ADD_BOOLEAN_BITFIELD(ancestorLineBoxDirty, AncestorLineBoxDirty); 787 ADD_BOOLEAN_BITFIELD(ancestorLineBoxDirty, AncestorLineBoxDirty);
789 788
790 // from RenderInline 789 // from RenderInline
791 ADD_BOOLEAN_BITFIELD(alwaysCreateLineBoxesForRenderInline, AlwaysCreateL ineBoxesForRenderInline); 790 ADD_BOOLEAN_BITFIELD(alwaysCreateLineBoxesForRenderInline, AlwaysCreateL ineBoxesForRenderInline);
792 791
793 private: 792 private:
794 unsigned m_positionedState : 2; // PositionedState 793 unsigned m_positionedState : 1; // PositionedState
795 unsigned m_selectionState : 3; // SelectionState 794 unsigned m_selectionState : 3; // SelectionState
796 795
797 public: 796 public:
798 bool isOutOfFlowPositioned() const { return m_positionedState == IsOutOf FlowPositioned; } 797 bool isOutOfFlowPositioned() const { return m_positionedState == IsOutOf FlowPositioned; }
799 bool isRelPositioned() const { return m_positionedState == IsRelativelyP ositioned; } 798 // FIXME(sky): Remove
799 bool isRelPositioned() const { return false; }
800 bool isPositioned() const { return m_positionedState != IsStaticallyPosi tioned; } 800 bool isPositioned() const { return m_positionedState != IsStaticallyPosi tioned; }
801 801
802 void setPositionedState(int positionState) 802 void setPositionedState(int positionState)
803 { 803 {
804 m_positionedState = static_cast<PositionedState>(positionState); 804 m_positionedState = static_cast<PositionedState>(positionState);
805 } 805 }
806 void clearPositionedState() { m_positionedState = StaticPosition; } 806 void clearPositionedState() { m_positionedState = StaticPosition; }
807 807
808 ALWAYS_INLINE SelectionState selectionState() const { return static_cast <SelectionState>(m_selectionState); } 808 ALWAYS_INLINE SelectionState selectionState() const { return static_cast <SelectionState>(m_selectionState); }
809 ALWAYS_INLINE void setSelectionState(SelectionState selectionState) { m_ selectionState = selectionState; } 809 ALWAYS_INLINE void setSelectionState(SelectionState selectionState) { m_ selectionState = selectionState; }
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
916 void showTree(const blink::RenderObject*); 916 void showTree(const blink::RenderObject*);
917 void showLineTree(const blink::RenderObject*); 917 void showLineTree(const blink::RenderObject*);
918 void showRenderTree(const blink::RenderObject* object1); 918 void showRenderTree(const blink::RenderObject* object1);
919 // We don't make object2 an optional parameter so that showRenderTree 919 // We don't make object2 an optional parameter so that showRenderTree
920 // can be called from gdb easily. 920 // can be called from gdb easily.
921 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2); 921 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2);
922 922
923 #endif 923 #endif
924 924
925 #endif // SKY_ENGINE_CORE_RENDERING_RENDEROBJECT_H_ 925 #endif // SKY_ENGINE_CORE_RENDERING_RENDEROBJECT_H_
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderLayerClipper.cpp ('k') | sky/engine/core/rendering/style/RenderStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698