pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart - Issue 904603004: rename completion constants and cleanup comment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 904603004: rename completion constants and cleanup comment (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart ('k') | pkg/analysis_server/lib/src/services/completion/imported_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

index 026bdf1d5a696a682ad087e946d9406e74e5c7d7..54bb27d95477cc820be165c7aa5d68355a368cb2 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

@@ -23,14 +23,8 @@ import 'package:analyzer/src/generated/engine.dart';

import 'package:analyzer/src/generated/source.dart';

import 'package:analyzer/src/generated/scanner.dart';

-// TODO (danrubel) these are temporary constants as we transition completion

-// relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int.

-// These should be removed in a subsequent CL

-const int COMPLETION_RELEVANCE_LOW = 500;

-const int COMPLETION_RELEVANCE_DEFAULT = 1000;

-const int COMPLETION_RELEVANCE_HIGH = 2000;

// Relevance highest to lowest

+const int DART_RELEVANCE_HIGH = 2000;

const int DART_RELEVANCE_LOCAL_VARIABLE = 1059;

const int DART_RELEVANCE_PARAMETER = 1059;

const int DART_RELEVANCE_INHERITED_FIELD = 1058;

@@ -42,6 +36,8 @@ const int DART_RELEVANCE_LOCAL_METHOD = 1057;

const int DART_RELEVANCE_LOCAL_FUNCTION = 1056;

const int DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE = 1056;

const int DART_RELEVANCE_KEYWORD = 1055;

+const int DART_RELEVANCE_DEFAULT = 1000;

+const int DART_RELEVANCE_LOW = 500;

/**

* The base class for computing code completion suggestions.