Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: base/threading/thread_checker_impl.h

Issue 904593002: Assert RendererScheduler thread usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mac Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/threading/thread_checker.h ('k') | content/renderer/scheduler/renderer_scheduler_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_THREADING_THREAD_CHECKER_IMPL_H_ 5 #ifndef BASE_THREADING_THREAD_CHECKER_IMPL_H_
6 #define BASE_THREADING_THREAD_CHECKER_IMPL_H_ 6 #define BASE_THREADING_THREAD_CHECKER_IMPL_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/compiler_specific.h"
9 #include "base/synchronization/lock.h" 10 #include "base/synchronization/lock.h"
10 #include "base/threading/platform_thread.h" 11 #include "base/threading/platform_thread.h"
11 12
12 namespace base { 13 namespace base {
13 14
14 // Real implementation of ThreadChecker, for use in debug mode, or 15 // Real implementation of ThreadChecker, for use in debug mode, or
15 // for temporary use in release mode (e.g. to CHECK on a threading issue 16 // for temporary use in release mode (e.g. to CHECK on a threading issue
16 // seen only in the wild). 17 // seen only in the wild).
17 // 18 //
18 // Note: You should almost always use the ThreadChecker class to get the 19 // Note: You should almost always use the ThreadChecker class to get the
19 // right version for your build configuration. 20 // right version for your build configuration.
20 class BASE_EXPORT ThreadCheckerImpl { 21 class BASE_EXPORT ThreadCheckerImpl {
21 public: 22 public:
22 ThreadCheckerImpl(); 23 ThreadCheckerImpl();
23 ~ThreadCheckerImpl(); 24 ~ThreadCheckerImpl();
24 25
25 bool CalledOnValidThread() const; 26 bool CalledOnValidThread() const WARN_UNUSED_RESULT;
26 27
27 // Changes the thread that is checked for in CalledOnValidThread. This may 28 // Changes the thread that is checked for in CalledOnValidThread. This may
28 // be useful when an object may be created on one thread and then used 29 // be useful when an object may be created on one thread and then used
29 // exclusively on another thread. 30 // exclusively on another thread.
30 void DetachFromThread(); 31 void DetachFromThread();
31 32
32 private: 33 private:
33 void EnsureThreadIdAssigned() const; 34 void EnsureThreadIdAssigned() const;
34 35
35 mutable base::Lock lock_; 36 mutable base::Lock lock_;
36 // This is mutable so that CalledOnValidThread can set it. 37 // This is mutable so that CalledOnValidThread can set it.
37 // It's guarded by |lock_|. 38 // It's guarded by |lock_|.
38 mutable PlatformThreadRef valid_thread_id_; 39 mutable PlatformThreadRef valid_thread_id_;
39 }; 40 };
40 41
41 } // namespace base 42 } // namespace base
42 43
43 #endif // BASE_THREADING_THREAD_CHECKER_IMPL_H_ 44 #endif // BASE_THREADING_THREAD_CHECKER_IMPL_H_
OLDNEW
« no previous file with comments | « base/threading/thread_checker.h ('k') | content/renderer/scheduler/renderer_scheduler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698