Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 904573002: Revert of Move tracing namespace from base::debug to base::trace_event. (Closed)

Created:
5 years, 10 months ago by zhaoqin1
Modified:
5 years, 10 months ago
CC:
nduca
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_trace_part1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move tracing namespace from base::debug to base::trace_event. (patchset #7 id:120001 of https://codereview.chromium.org/882673002/) Reason for revert: broken Memory.FYI TSan bot. crbug.com/455530 Original issue's description: > Move tracing namespace from base::debug to base::trace_event. > > After having transitioned all the tracing headers from base/debug/ to > base/trace_event, this CL addresses the namespace move. > In principle, this CL should only change the namespace of the > base/trace_event files but the namespace used by the tracing clients. > In order to achieve this, namespace aliases are appended to the > trace_event headers, to make it so that clients can still refer to > base::debug::TraceFoo, with that being aliased to > base::trace_event::TraceFoo. > The upcoming CLs will gradually migrate the clients to use the > base::trace_event namespace and will remove the ns aliases. > Unfortunately, this CL has also to update few tracing clients, > in particular the ones having forward declarations. Forward > declarations, in fact, cannot be aliased as the compiler sees them > before the alias itself. > > See crrev.com/837303004 and the related bug for motivations and design doc. > > BUG=451032 > TBR=skyostil@chromium.org,jam@chromium.org > > Committed: https://crrev.com/97c5abba36f5ce473cd996fab74fbf5aa9bb5464 > Cr-Commit-Position: refs/heads/master@{#314657} TBR=dsinclair@chromium.org,picksi@chromium.org,primiano@chromium.org,skyostil@chromium.org,ssid@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451032 Committed: https://crrev.com/c7c37ff30cd9dbacfaef0eef5a6b2b53cdae905c Cr-Commit-Position: refs/heads/master@{#314740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -395 lines) Patch
M base/trace_event/trace_event.h View 26 chunks +41 lines, -57 lines 0 comments Download
M base/trace_event/trace_event_android.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M base/trace_event/trace_event_argument.h View 2 chunks +1 line, -9 lines 0 comments Download
M base/trace_event/trace_event_argument.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_argument_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 3 chunks +4 lines, -21 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_impl_constants.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_memory.h View 4 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_memory.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/trace_event/trace_event_memory_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_synthetic_delay.h View 3 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_synthetic_delay.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M base/trace_event/trace_event_synthetic_delay_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_system_stats_monitor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/trace_event/trace_event_system_stats_monitor.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_system_stats_monitor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_win.h View 2 chunks +1 line, -15 lines 0 comments Download
M base/trace_event/trace_event_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/base/math_util.h View 1 chunk +1 line, -8 lines 0 comments Download
M cc/base/region.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/blink/web_layer_impl.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/debug/traced_value.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/layers/layer.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/layers/layer_client.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +2 lines, -8 lines 0 comments Download
M cc/output/begin_frame_args.h View 1 chunk +1 line, -8 lines 0 comments Download
M cc/output/filter_operation.h View 1 chunk +2 lines, -8 lines 0 comments Download
M cc/output/filter_operations.h View 1 chunk +2 lines, -8 lines 0 comments Download
M cc/quads/draw_quad.h View 1 chunk +2 lines, -8 lines 0 comments Download
M cc/quads/render_pass.h View 1 chunk +2 lines, -8 lines 0 comments Download
M cc/quads/shared_quad_state.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/resources/bitmap_tile_task_worker_pool.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/resources/one_copy_tile_task_worker_pool.h View 1 chunk +1 line, -8 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/resources/pixel_buffer_tile_task_worker_pool.h View 1 chunk +1 line, -8 lines 0 comments Download
M cc/resources/tile_manager.h View 1 chunk +1 line, -8 lines 0 comments Download
M cc/resources/zero_copy_tile_task_worker_pool.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/scheduler/delay_based_time_source.h View 1 chunk +2 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler.h View 1 chunk +2 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 chunk +2 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -7 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +2 lines, -8 lines 0 comments Download
M content/browser/browser_main_loop.h View 1 chunk +1 line, -8 lines 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +1 line, -7 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.h View 1 chunk +1 line, -7 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.h View 1 chunk +1 line, -8 lines 0 comments Download
M content/renderer/scheduler/task_queue_selector.h View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zhaoqin1
Created Revert of Move tracing namespace from base::debug to base::trace_event.
5 years, 10 months ago (2015-02-05 03:49:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904573002/1
5 years, 10 months ago (2015-02-05 03:50:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 03:51:31 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 03:52:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7c37ff30cd9dbacfaef0eef5a6b2b53cdae905c
Cr-Commit-Position: refs/heads/master@{#314740}

Powered by Google App Engine
This is Rietveld 408576698