Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 904553002: Make pinch-zoom work for OOP PDF (Closed)

Created:
5 years, 10 months ago by raymes
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, wjmaclean, bokan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make pinch-zoom work for OOP PDF There are two changes to make this work: -Set the plugins width/height to 100%. We will soon be using this for the material layout as well. -Allow MimeHandlerViewGuests to handle pinch gestures when they are full-page plugins. BUG=453729 Committed: https://crrev.com/f0db15c17e5abb7c6dccdc11bcfffcb2d8ce835c Cr-Commit-Position: refs/heads/master@{#314742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M chrome/browser/resources/pdf/index.css View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 3 chunks +5 lines, -13 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
raymes
5 years, 10 months ago (2015-02-05 02:11:34 UTC) #2
Fady Samuel
guest_view lgtm
5 years, 10 months ago (2015-02-05 02:24:59 UTC) #3
Sam McNally
lgtm
5 years, 10 months ago (2015-02-05 02:43:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904553002/1
5 years, 10 months ago (2015-02-05 02:58:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 03:55:25 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 03:56:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0db15c17e5abb7c6dccdc11bcfffcb2d8ce835c
Cr-Commit-Position: refs/heads/master@{#314742}

Powered by Google App Engine
This is Rietveld 408576698