Issue 904533002: Add CrashReportDatabase::ErrorWritingCrashReport()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 904533002: Add CrashReportDatabase::ErrorWritingCrashReport() (Closed)

Created:
5 years, 10 months ago by Mark Mentovai

Modified:
5 years, 10 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org, scottmg

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Add CrashReportDatabase::ErrorWritingCrashReport(). A crash handler needs a way to clean up after itself it it calls CrashReportDatabase::PrepareCrashReport() to begin writing a new crash report, but then encounters an error that renders the crash report unusable. The new ErrorWritingCrashReport() method allows it to communicate to the database that a previously-prepared crash report should be removed without ever being promoted to a completed report pending upload. TEST=client_test CrashReportDatabaseTest.ErrorWritingCrashReport R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5d0050dee7011ff916531124d9f2201560db26de

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -2 lines)			Patch
M	client/crash_report_database.h	View	3 chunks	+15 lines, -2 lines	0 comments	Download
M	client/crash_report_database_mac.mm	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	client/crash_report_database_test.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

5 years, 10 months ago (2015-02-04 21:33:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5d0050dee7011ff916531124d9f2201560db26de (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages