Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 904513006: Roll PDFium to bring in: (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium to bring in: 7061d1a Update GN files from previous commit as well. 1be2034 Initialize V8 outside of PDFium. 62120b7 Prevent base::CheckedNumeric from leaking outside of pdfium. c32dac1 Replace CFX_SmartPointer cast operator with Get() method. 0c01ad0 Fix stack exhaustion in CPDF_DataAvail::HaveResourceAncestor() BUG=455399 TBR=tsepez Committed: https://crrev.com/090bd6fb8755608bd575dc46b1f7cc75aea74433 Cr-Commit-Position: refs/heads/master@{#314729}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
jam
5 years, 10 months ago (2015-02-05 00:07:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904513006/1
5 years, 10 months ago (2015-02-05 00:07:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/5086) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/39540)
5 years, 10 months ago (2015-02-05 00:17:52 UTC) #6
Tom Sepez
RS LGTM
5 years, 10 months ago (2015-02-05 00:33:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904513006/20001
5 years, 10 months ago (2015-02-05 01:03:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/30823)
5 years, 10 months ago (2015-02-05 02:19:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904513006/20001
5 years, 10 months ago (2015-02-05 02:32:40 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 03:06:50 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 03:07:36 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/090bd6fb8755608bd575dc46b1f7cc75aea74433
Cr-Commit-Position: refs/heads/master@{#314729}

Powered by Google App Engine
This is Rietveld 408576698