Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 904513005: [NaCl SDK] Update fancy_urllib to more recent version. (Closed)

Created:
5 years, 10 months ago by binji
Modified:
5 years, 10 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Update fancy_urllib to more recent version. This includes a fix for Python 2.7.7, which removed the HTTPSConnection._set_hostport function. BUG=410545 R=sbc@chromium.org Committed: https://crrev.com/6d97ebda5078f7f62e6dd47f316ad43fabb64d07 Cr-Commit-Position: refs/heads/master@{#314672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -50 lines) Patch
M native_client_sdk/src/build_tools/sdk_tools/third_party/fancy_urllib/__init__.py View 11 chunks +112 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
binji
5 years, 10 months ago (2015-02-04 22:35:30 UTC) #1
Sam Clegg
Do you need to update the README.chromium for this as well? Otherwise lgtm.
5 years, 10 months ago (2015-02-04 22:37:18 UTC) #2
binji
On 2015/02/04 22:37:18, Sam Clegg wrote: > Do you need to update the README.chromium for ...
5 years, 10 months ago (2015-02-04 22:51:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904513005/1
5 years, 10 months ago (2015-02-04 22:52:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 23:11:54 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 23:12:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d97ebda5078f7f62e6dd47f316ad43fabb64d07
Cr-Commit-Position: refs/heads/master@{#314672}

Powered by Google App Engine
This is Rietveld 408576698