Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 904513002: Update sync promo string in chrome://settings (Closed)

Created:
5 years, 10 months ago by noms (inactive)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update sync promo string in chrome://settings BUG=455273 Committed: https://crrev.com/fdef2865f067f30e99f1f11b33d8811d98bf1e54 Cr-Commit-Position: refs/heads/master@{#314875} Committed: https://crrev.com/5f2fff5935cd8ab98a4b464201c149bebbf89b13 Cr-Commit-Position: refs/heads/master@{#315414}

Patch Set 1 #

Patch Set 2 : fix compile, update string #

Total comments: 2

Patch Set 3 : try to clean up ifdef soup and not break everything #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -118 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 9 chunks +105 lines, -117 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
noms (inactive)
5 years, 10 months ago (2015-02-04 20:26:34 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
5 years, 10 months ago (2015-02-05 20:57:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904513002/1
5 years, 10 months ago (2015-02-05 20:58:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 21:02:52 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fdef2865f067f30e99f1f11b33d8811d98bf1e54 Cr-Commit-Position: refs/heads/master@{#314875}
5 years, 10 months ago (2015-02-05 21:05:03 UTC) #7
noms (inactive)
+ dan for a browser_options_handler review.
5 years, 10 months ago (2015-02-09 18:52:59 UTC) #10
noms (inactive)
(this was reverted in https://codereview.chromium.org/884743004)
5 years, 10 months ago (2015-02-09 18:54:50 UTC) #11
Dan Beam
lgtm https://codereview.chromium.org/904513002/diff/20001/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): https://codereview.chromium.org/904513002/diff/20001/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode211 chrome/browser/ui/webui/options/browser_options_handler.cc:211: #endif // defined(OS_CHROMEOS) nit: this #if soup needs ...
5 years, 10 months ago (2015-02-09 19:42:04 UTC) #12
Dan Beam
lgtm++ break all the chromes
5 years, 10 months ago (2015-02-09 21:22:27 UTC) #14
noms (inactive)
https://codereview.chromium.org/904513002/diff/20001/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): https://codereview.chromium.org/904513002/diff/20001/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode211 chrome/browser/ui/webui/options/browser_options_handler.cc:211: #endif // defined(OS_CHROMEOS) On 2015/02/09 19:42:03, Dan Beam wrote: ...
5 years, 10 months ago (2015-02-09 21:27:18 UTC) #15
noms (inactive)
On 2015/02/09 21:22:27, Dan Beam wrote: > lgtm++ break all the chromes SHIPPING IT.
5 years, 10 months ago (2015-02-09 21:28:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904513002/40001
5 years, 10 months ago (2015-02-09 21:30:31 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 22:38:51 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:39:50 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f2fff5935cd8ab98a4b464201c149bebbf89b13
Cr-Commit-Position: refs/heads/master@{#315414}

Powered by Google App Engine
This is Rietveld 408576698