Issue 904503003: Mac: Make more views adopts ThemedWindowDrawing

Issue 904503003: Mac: Make more views adopts ThemedWindowDrawing (Closed)

Created:
5 years, 10 months ago by Andre

Modified:
5 years, 10 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@FramedBrowserWindow

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Mac: Make more views adopts ThemedWindowDrawing Follow up to https://codereview.chromium.org/900613003/. Make NewTabButton and TabStripBackgroundView adopt ThemedWindowDrawing. BUG=455955, 453996 Committed: https://crrev.com/bd3cb0be95adaa666858c4a7b4b498f57c624a43 Cr-Commit-Position: refs/heads/master@{#315061}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -27 lines)			Patch
M	chrome/browser/ui/cocoa/new_tab_button.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/new_tab_button.mm	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_background_view.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_background_view.mm	View	1 chunk	+5 lines, -25 lines	0 comments	Download

Total messages: 8 (2 generated)

Andre

Avi, please review. https://codereview.chromium.org/900613003/ actually introduced a bug where NewTabButton does not redraw when changing ...

5 years, 10 months ago (2015-02-04 22:41:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904503003/1

5 years, 10 months ago (2015-02-06 17:44:15 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-06 17:48:42 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bd3cb0be95adaa666858c4a7b4b498f57c624a43
Cr-Commit-Position: refs/heads/master@{#315061}