runtime/vm/parser.cc - Issue 904443002: VM: Fix source location in stack trace of async code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 904443002: VM: Fix source location in stack trace of async code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 43463)

+++ runtime/vm/parser.cc (working copy)

@@ -5945,7 +5945,7 @@

completer_args->Add(

new (Z) LoadLocalNode(Scanner::kNoSourcePos, stack_trace_param.var));

current_block_->statements->Add(new (Z) InstanceCallNode(

- Scanner::kNoSourcePos,

+ TokenPos(),

new (Z) LoadLocalNode(Scanner::kNoSourcePos, async_completer),

Symbols::CompleterCompleteError(),

completer_args));

@@ -6234,7 +6234,7 @@

current_block_->statements->Add(store_async_op);

// Add to AST:

- // new Future(:async_op);

+ // new Future.microtask(:async_op);

ArgumentListNode* arguments = new (Z) ArgumentListNode(Scanner::kNoSourcePos);

arguments->Add(new (Z) LoadLocalNode(

Scanner::kNoSourcePos, async_op_var));

@@ -9416,7 +9416,7 @@

TRACE_PARSER("ParseAwaitExpr");

ConsumeToken();

parsed_function()->record_await();

- expr = new (Z) AwaitNode(TokenPos(), ParseUnaryExpr());

+ expr = new (Z) AwaitNode(op_pos, ParseUnaryExpr());

} else if (IsPrefixOperator(CurrentToken())) {

Token::Kind unary_op = CurrentToken();

if (unary_op == Token::kSUB) {

« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »