src/lookup.cc - Issue 904423002: fix transition of typedarrays in ics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 904423002: fix transition of typedarrays in ics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index c658a90e63fb816f831d7c82caa931579388cd01..a2ae54df4324e47b2afd7d705b4cd680d27702e1 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -120,7 +120,7 @@ void LookupIterator::PrepareTransitionToDataProperty(

if (state_ == TRANSITION) return;

DCHECK(state_ != LookupIterator::ACCESSOR);

DCHECK(state_ == NOT_FOUND || !HolderIsReceiverOrHiddenPrototype());

+ DCHECK(!IsSpecialNumericIndex());

// Can only be called when the receiver is a JSObject. JSProxy has to be

// handled via a trap. Adding properties to primitive values is not

// observable.

« no previous file with comments | « src/ic/ic.cc ('k') | test/mjsunit/harmony/regress/regress-typedarray-out-of-bounds.js » ('j') | no next file with comments »