Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Side by Side Diff: src/ic/ic.cc

Issue 904423002: fix transition of typedarrays in ics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 1490 matching lines...) Expand 10 before | Expand all | Expand 10 after
1501 return it->GetHolder<Object>().is_identical_to( 1501 return it->GetHolder<Object>().is_identical_to(
1502 PrototypeIterator::GetCurrent(iter)); 1502 PrototypeIterator::GetCurrent(iter));
1503 } 1503 }
1504 1504
1505 it->PrepareTransitionToDataProperty(value, NONE, store_mode); 1505 it->PrepareTransitionToDataProperty(value, NONE, store_mode);
1506 return it->IsCacheableTransition(); 1506 return it->IsCacheableTransition();
1507 } 1507 }
1508 } 1508 }
1509 } 1509 }
1510 1510
1511 if (it->IsSpecialNumericIndex()) return false;
1511 it->PrepareTransitionToDataProperty(value, NONE, store_mode); 1512 it->PrepareTransitionToDataProperty(value, NONE, store_mode);
1512 return it->IsCacheableTransition(); 1513 return it->IsCacheableTransition();
1513 } 1514 }
1514 1515
1515 1516
1516 MaybeHandle<Object> StoreIC::Store(Handle<Object> object, Handle<Name> name, 1517 MaybeHandle<Object> StoreIC::Store(Handle<Object> object, Handle<Name> name,
1517 Handle<Object> value, 1518 Handle<Object> value,
1518 JSReceiver::StoreFromKeyed store_mode) { 1519 JSReceiver::StoreFromKeyed store_mode) {
1519 if (FLAG_harmony_scoping && object->IsGlobalObject() && name->IsString()) { 1520 if (FLAG_harmony_scoping && object->IsGlobalObject() && name->IsString()) {
1520 // Look up in script context table. 1521 // Look up in script context table.
(...skipping 1475 matching lines...) Expand 10 before | Expand all | Expand 10 after
2996 static const Address IC_utilities[] = { 2997 static const Address IC_utilities[] = {
2997 #define ADDR(name) FUNCTION_ADDR(name), 2998 #define ADDR(name) FUNCTION_ADDR(name),
2998 IC_UTIL_LIST(ADDR) NULL 2999 IC_UTIL_LIST(ADDR) NULL
2999 #undef ADDR 3000 #undef ADDR
3000 }; 3001 };
3001 3002
3002 3003
3003 Address IC::AddressFromUtilityId(IC::UtilityId id) { return IC_utilities[id]; } 3004 Address IC::AddressFromUtilityId(IC::UtilityId id) { return IC_utilities[id]; }
3004 } 3005 }
3005 } // namespace v8::internal 3006 } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698