Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 904403002: Make the position of 'n files selected' label synced with the width of navigation list. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the position of 'n files selected' label synced with the width of navigation list. BUG=402344 TEST=select some items, drag the separator for navigation list, and check that the 'n files selected' label is synced with the separator's position.

Patch Set 1 #

Patch Set 2 : Set initial width for #cancel-selection-button-wrapper, used before the first relayout event. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -10 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 chunks +6 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/toolbar_controller.js View 4 chunks +25 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 2 chunks +16 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
fukino
Could you take a look? Thanks!
5 years, 10 months ago (2015-02-09 05:58:52 UTC) #2
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-09 07:35:50 UTC) #3
fukino
Thanks!
5 years, 10 months ago (2015-02-09 07:36:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904403002/20001
5 years, 10 months ago (2015-02-09 07:37:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/121104) win_gpu_triggered_tests on tryserver.chromium.gpu (JOB_FAILED, ...
5 years, 10 months ago (2015-02-09 08:00:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904403002/20001
5 years, 10 months ago (2015-02-09 08:07:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/53457)
5 years, 10 months ago (2015-02-09 08:37:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904403002/20001
5 years, 10 months ago (2015-02-09 10:43:48 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3202364f5ec3ad0903791593d3021c34e9c4c8da Cr-Commit-Position: refs/heads/master@{#315283}
5 years, 10 months ago (2015-02-09 13:03:52 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 13:04:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698