Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 904393003: Files.app: allow stretching thumbnails in file list. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: allow stretching thumbnails in file list. BUG=453704 TEST=place small image on Drive and Downloads, and check if the thumbnail box/circle is filled in grid view and list view. Committed: https://crrev.com/0e8f7d83dd357e35631e9f538c520577dad73b0c Cr-Commit-Position: refs/heads/master@{#315294}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +5 lines, -0 lines 2 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
fukino
Could you take a look? Thanks! https://codereview.chromium.org/904393003/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/904393003/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode1223 ui/file_manager/file_manager/foreground/css/file_manager.css:1223: position: absolute; This ...
5 years, 10 months ago (2015-02-09 11:03:41 UTC) #2
yawano
lgtm. Thank you! https://codereview.chromium.org/904393003/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/904393003/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode1223 ui/file_manager/file_manager/foreground/css/file_manager.css:1223: position: absolute; On 2015/02/09 11:03:41, fukino ...
5 years, 10 months ago (2015-02-09 11:15:05 UTC) #3
fukino
On 2015/02/09 11:15:05, yawano wrote: > lgtm. Thank you! > > https://codereview.chromium.org/904393003/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css > File ui/file_manager/file_manager/foreground/css/file_manager.css ...
5 years, 10 months ago (2015-02-09 11:26:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904393003/1
5 years, 10 months ago (2015-02-09 11:27:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ng on ...
5 years, 10 months ago (2015-02-09 13:28:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904393003/1
5 years, 10 months ago (2015-02-09 14:14:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 14:15:04 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 14:15:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e8f7d83dd357e35631e9f538c520577dad73b0c
Cr-Commit-Position: refs/heads/master@{#315294}

Powered by Google App Engine
This is Rietveld 408576698