Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 904373002: X87: Continue learning for calls in crankshaft. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Continue learning for calls in crankshaft. port 7d363783e14433032a4e8dd426fe0e27d1637fe5. original commit message: Continue learning for calls in crankshaft. The type feedback vector makes this easy to do. This is a re-land of https://codereview.chromium.org/868453005/ with a fix for the DCHECK failure. BUG= R=weiliang.lin@intel.com Committed: https://crrev.com/f50a556bd0652841924c37c01ecf583005da22eb Cr-Commit-Position: refs/heads/master@{#26506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -5 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +24 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +8 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-09 04:52:49 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 05:15:18 UTC) #3
Weiliang
lgtm lgtm
5 years, 10 months ago (2015-02-09 05:15:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f50a556bd0652841924c37c01ecf583005da22eb Cr-Commit-Position: refs/heads/master@{#26506}
5 years, 10 months ago (2015-02-09 05:19:35 UTC) #5
chunyang.dai
5 years, 10 months ago (2015-02-09 05:19:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f50a556bd0652841924c37c01ecf583005da22eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698