Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 904273002: Add the ability to logout. (Closed)

Created:
5 years, 10 months ago by esprehn
Modified:
5 years, 10 months ago
Reviewers:
jrobbins, ojan
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M appengine/chromium_rietveld/new_static/components/cr-app.html View 4 chunks +18 lines, -16 lines 1 comment Download
M appengine/chromium_rietveld/new_static/model/user.js View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
esprehn
5 years, 10 months ago (2015-02-08 05:10:41 UTC) #2
ojan
lgtm https://codereview.chromium.org/904273002/diff/1/appengine/chromium_rietveld/new_static/components/cr-app.html File appengine/chromium_rietveld/new_static/components/cr-app.html (right): https://codereview.chromium.org/904273002/diff/1/appengine/chromium_rietveld/new_static/components/cr-app.html#newcode165 appengine/chromium_rietveld/new_static/components/cr-app.html:165: location.href = User.getLogoutUrl(); It's kinda funny to recreate ...
5 years, 10 months ago (2015-02-08 05:49:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904273002/1
5 years, 10 months ago (2015-02-08 05:49:16 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-08 05:51:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/b30c5dc85a95c4a76b3f77b1224f5...

Powered by Google App Engine
This is Rietveld 408576698