[components/crash] Add crash client method to enable microdumps

components/crash/app/breakpad_linux.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // For linux_syscall_support.h. This makes it safe to call embedded system
 // calls when in seccomp mode.
 
 #include "components/crash/app/breakpad_linux.h"
 
 #include <fcntl.h>
@@ skipping 696 matching lines @@
   if (!succeeded) {
     static const char msg[] = "Microdump crash handler failed.\n";
     WriteLog(msg, sizeof(msg) - 1);
     return false;
   }
 
   const bool is_browser_process = (context != NULL);
   return FinalizeCrashDoneAndroid(is_browser_process);
  }
 
-// When unwind tables are stripped out (to save binary size) the stack traces
-// produced locally in the case of a crash / CHECK are meaningless. In order to
-// provide meaningful development diagnostics (and keep the binary size savings)
-// on Android we attach a secondary crash handler, in addition to the breakpad
-// minidump uploader (which depends on the user consent).
 // The microdump handler does NOT upload anything. It just dumps out on the
 // system console (logcat) a restricted and serialized variant of a minidump.
 // See crbug.com/410294 for more details.
 void InitMicrodumpCrashHandlerIfNecessary(const std::string& process_type) {
-#if !defined(NO_UNWIND_TABLES) \
-    || (!defined(ARCH_CPU_ARMEL) && !defined(ARCH_CPU_ARM64))
+#if (!defined(ARCH_CPU_ARMEL) && !defined(ARCH_CPU_ARM64))
   // TODO(primiano): For the moment microdumps are enabled only on arm (32/64).
   // Extend support to other architectures (requires some breakpad changes).
   return;
 #endif
+
+  if (!GetCrashReporterClient()->ShouldEnableBreakpadMicrodumps())
+    return;
+
   VLOG(1) << "Enabling microdumps crash handler (process_type:"
           << process_type << ")";
   DCHECK(!g_microdump);
   g_microdump = new ExceptionHandler(
         MinidumpDescriptor(MinidumpDescriptor::kMicrodumpOnConsole),
         NULL,
         MicrodumpCrashDone,
         reinterpret_cast<void*>(process_type.empty()),
         true,  // Install handlers.
         -1);   // Server file descriptor. -1 for in-process.
@@ skipping 967 matching lines @@
     }
   }
 }
 #endif  // OS_ANDROID
 
 bool IsCrashReporterEnabled() {
   return g_is_crash_reporter_enabled;
 }
 
 }  // namespace breakpad