Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: content/renderer/media/media_stream_audio_processor_options.h

Issue 904203003: UMA histogram WebRTC.AecDelayBasedQuality updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments by perkj@ Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_audio_processor_options.h
diff --git a/content/renderer/media/media_stream_audio_processor_options.h b/content/renderer/media/media_stream_audio_processor_options.h
index eaa85f7b9538268b26fae8e7b9eb217d8f7f6125..d0a8286627f3b2fa2fa10c9d9b205147c031495d 100644
--- a/content/renderer/media/media_stream_audio_processor_options.h
+++ b/content/renderer/media/media_stream_audio_processor_options.h
@@ -8,7 +8,6 @@
#include <string>
#include "base/files/file.h"
-#include "base/time/time.h"
#include "content/common/content_export.h"
#include "third_party/WebKit/public/platform/WebMediaConstraints.h"
#include "third_party/libjingle/source/talk/app/webrtc/mediastreaminterface.h"
@@ -17,6 +16,7 @@ namespace webrtc {
class AudioFrame;
class AudioProcessing;
+class EchoCancellation;
class MediaConstraintsInterface;
class TypingDetection;
@@ -93,18 +93,17 @@ class CONTENT_EXPORT EchoInformation {
EchoInformation();
virtual ~EchoInformation();
- // Updates delay statistics with a new |delay|.
- void UpdateAecDelayStats(int delay);
+ void UpdateAecDelayStats(webrtc::EchoCancellation* echo_cancellation);
private:
- // Updates UMA histograms with an interval of |kTimeBetweenLogsInSeconds|.
+ // Updates UMA histograms with an interval of 5 seconds.
void LogAecDelayStats();
- // Counters for determining how often the estimated delay in the AEC is out of
- // bounds.
- int echo_poor_delay_counts_;
- int echo_total_delay_counts_;
- base::TimeTicks last_log_time_;
+ // Counters to be able to aquire a 5 second aggregated metric out of 1 second
+ // aggregated webrtc::EchoCancellation::GetEchoDelayMetrics() queries.
+ int num_chunks_;
+ int num_queries_;
+ float echo_fraction_poor_delays_;
DISALLOW_COPY_AND_ASSIGN(EchoInformation);
};

Powered by Google App Engine
This is Rietveld 408576698