Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 904203003: UMA histogram WebRTC.AecDelayBasedQuality updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1c352d72174a1b7dc69c401f821b33c219a132e0..7e65274805d71f43c13b1ef1afaff0f281ba51e6 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -41913,9 +41913,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>
Captures if the estimated delay between rendered and captured audio is out
of bounds which can cause the Echo Cancellation to fail. This is logged
- roughly ones every 5 seconds, but only if there is an application that calls
- GetStats(). The values are logged in three buckets reflecting how well the
- Echo Cancellation likely performs based on the estimated delay.
+ roughly once every 5 seconds. The values are logged in four buckets
+ reflecting how well the Echo Cancellation likely performs based on the
+ estimated delay.
</summary>
</histogram>
@@ -44874,12 +44874,12 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</enum>
<enum name="DelayBasedEchoQuality" type="int">
- <int value="0"
- label="Delay in bounds: Echo Cancellation quality most likely good"/>
+ <int value="0" label="Invalid delays: Insufficient amount of data"/>
perkj_chrome 2015/02/09 07:53:14 I don't think you can change the meaning of existe
bjornv 2015/02/09 11:11:16 Changed order, but letting asvitkine to decide whe
<int value="1"
- label="Delay spuriously out of bounds: Echo Cancellation may suffer"/>
+ label="Delay in bounds: Echo Cancellation quality most likely good"/>
<int value="2"
- label="Delay out of bounds: Echo Cancellation most likely fails"/>
+ label="Delay spuriously out of bounds: Echo Cancellation may suffer"/>
+ <int value="3" label="Delay out of bounds: Echo Cancellation likely fails"/>
</enum>
<enum name="DesktopCaptureCounters" type="int">

Powered by Google App Engine
This is Rietveld 408576698