Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4191)

Unified Diff: chrome/views/chrome_menu.cc

Issue 9042: Adds support for autoscrolling on drag to bookmark tree/table.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/views/chrome_menu.cc
===================================================================
--- chrome/views/chrome_menu.cc (revision 4555)
+++ chrome/views/chrome_menu.cc (working copy)
@@ -23,6 +23,7 @@
#include "chrome/views/border.h"
#include "chrome/views/container_win.h"
#include "chrome/views/root_view.h"
+#include "chrome/views/view_constants.h"
#include "generated_resources.h"
#undef min
@@ -1035,9 +1036,6 @@
// static
const int MenuItemView::kMenuItemViewID = 1001;
-// static
-const int MenuItemView::kDropBetweenPixels = 5;
-
// static
bool MenuItemView::allow_task_nesting_during_run_ = false;
@@ -1891,9 +1889,8 @@
if (!over_empty_menu) {
int menu_item_height = menu_item->height();
if (menu_item->HasSubmenu() &&
- (menu_item_loc.y() > MenuItemView::kDropBetweenPixels &&
- menu_item_loc.y() < (menu_item_height -
- MenuItemView::kDropBetweenPixels))) {
+ (menu_item_loc.y() > kDropBetweenPixels &&
+ menu_item_loc.y() < (menu_item_height - kDropBetweenPixels))) {
drop_position = MenuDelegate::DROP_ON;
} else if (menu_item_loc.y() < menu_item_height / 2) {
drop_position = MenuDelegate::DROP_BEFORE;

Powered by Google App Engine
This is Rietveld 408576698