Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 904163002: telemetry, mac: Stop using the fake keychain for telemetry tests. (Closed)

Created:
5 years, 10 months ago by erikchen
Modified:
5 years, 10 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, dtu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

telemetry, mac: Stop using the fake keychain for telemetry tests. The telemetry tests stopped using the real OSX keychain because the 10.9 machines were incorrectly configured. The 10.9 machines have had their keychains fixed (Issue 397385). I've also added checks so that key Telemetry tests log error messages if the OSX keychain is incorrectly configured (http://code.google.com/p/chromium/issues/detail?id=443340#c3). BUG=443340 Committed: https://crrev.com/6c0cdb70ade70eafb0503c1e223ac3e1b10af087 Cr-Commit-Position: refs/heads/master@{#315385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
nednguyen: Please review. Before I land this CL, I will coordinate with the perf sheriffs.
5 years, 10 months ago (2015-02-07 00:26:56 UTC) #2
nednguyen
lgtm
5 years, 10 months ago (2015-02-07 00:41:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904163002/1
5 years, 10 months ago (2015-02-09 19:46:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 20:52:14 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:00:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c0cdb70ade70eafb0503c1e223ac3e1b10af087
Cr-Commit-Position: refs/heads/master@{#315385}

Powered by Google App Engine
This is Rietveld 408576698