Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 904143003: [ycm] The YouCompleteMe configuration is not VIM specific. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ycm] The YouCompleteMe configuration is not VIM specific. Rename tools/vim/v8.ycm_extra_conf.py to .ycm_extra_conf.py, so every YCM plugin (no matter if it's VIM or Emacs) should pick it up automatically. Also move the common tools/vim/ninja_output.py to tools/ninja/ as it's also not related to VIM. Committed: https://crrev.com/42c30b8f399e390d0705bed9b4b92988f780c6da Cr-Commit-Position: refs/heads/master@{#26602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -247 lines) Patch
A + .ycm_extra_conf.py View 2 chunks +2 lines, -6 lines 0 comments Download
A + tools/ninja/ninja_output.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/vim/ninja-build.vim View 1 chunk +1 line, -1 line 0 comments Download
D tools/vim/ninja_output.py View 1 chunk +0 lines, -44 lines 0 comments Download
D tools/vim/v8.ycm_extra_conf.py View 1 chunk +0 lines, -197 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-12 07:10:37 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-12 07:17:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904143003/1
5 years, 10 months ago (2015-02-12 07:19:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 07:21:12 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 07:21:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42c30b8f399e390d0705bed9b4b92988f780c6da
Cr-Commit-Position: refs/heads/master@{#26602}

Powered by Google App Engine
This is Rietveld 408576698