Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0

Update mojo sdk to rev 8d45c89c30b230843c5bd6dd0693a555750946c0

[Taken over from blundell's https://codereview.chromium.org/901843003/,
PS3.]

Adapt to de-clienting of Surface.

Have nacl_listener pass a SimplePlatformSupport instance to
mojo::embedder::Init to satisfy the DCHECK introduced in
https://codereview.chromium.org/898623002/diff/40001/mojo/edk/embedder/embedder.cc.

[Additional fix backported from
https://codereview.chromium.org/898423002/.]

Fix mojo::embedder::CreateChannel(): the evaluation order between the
channel_info->channel_id and channel_info.release() is undefined.

[Additional "fix" backported from
https://codereview.chromium.org/903933006/.]

Add an "unnecessary" .Pass() to try to placate MSVS.

[Additional fix:]

surfaces_service.mojom.h -> surfaces.mojom.h

R=jamesr@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_dbg,win8_chromium_gn_rel

Committed: https://crrev.com/ac702dad4e2b64caacb84c9c5114d4d45456e183
Cr-Commit-Position: refs/heads/master@{#315161}

[viettrungluu, 2015-02-06 22:27:49]

OK, green enough for TV (or is that "it's not easy being green"?).

[viettrungluu, 2015-02-06 22:27:59]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2015-02-06 22:28:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/904103003/1

[jamesr, 2015-02-06 22:31:36]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-02-06 22:31:38]

lgtm

https://codereview.chromium.org/904103003/diff/1/components/nacl/loader/nacl_...
File components/nacl/loader/nacl_listener.cc (right):

https://codereview.chromium.org/904103003/diff/1/components/nacl/loader/nacl_...
components/nacl/loader/nacl_listener.cc:437:
mojo::embedder::Init(scoped_ptr<mojo::embedder::PlatformSupport>(
nit: you can just say make_scoped_ptr(new mojo::....), scoped_ptr<T> can be
rvalue-constructed from scoped_ptr<U> when U is a subclass of T

[commit-bot: I haz the power, 2015-02-06 23:15:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-06 23:16:29]

Patchset 1 (id:??) landed as
https://crrev.com/c2e11810044fe5ff1c1b8588103671925a5b74fe
Cr-Commit-Position: refs/heads/master@{#315128}

[viettrungluu, 2015-02-06 23:54:51]

On 2015/02/06 23:16:29, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c2e11810044fe5ff1c1b8588103671925a5b74fe
> Cr-Commit-Position: refs/heads/master@{#315128}

Crap. Had to revert: https://codereview.chromium.org/877993004/

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4475

[1054/2776] CXX
obj/third_party/mojo_services/src/view_manager/public/cpp/lib/cpp.view_observer.obj
FAILED: ninja -t msvc -e environment.x86 --
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/mojo_services/src/view_manager/public/cpp/lib/cpp.view.obj.rsp
/c ../../third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc
/Foobj/third_party/mojo_services/src/view_manager/public/cpp/lib/cpp.view.obj
/Fdobj/third_party/mojo_services/src/view_manager/public/cpp/cpp_cc.pdb
e:\b\build\slave\win8_gn\build\src\third_party\mojo_services\src\view_manager\public\cpp\lib\view.cc(390)
: error C2248: 'mojo::StructPtr<mojo::ViewportMetrics>::StructPtr' : cannot
access private member declared in class 'mojo::StructPtr<mojo::ViewportMetrics>'
       
e:\b\build\slave\win8_gn\build\src\third_party\mojo\src\mojo\public\cpp\bindings\struct_ptr.h(31)
: see declaration of 'mojo::StructPtr<mojo::ViewportMetrics>::StructPtr'
ninja: build stopped: subcommand failed.

WAT

[jamesr, 2015-02-07 00:02:52]

On 2015/02/06 23:54:51, viettrungluu wrote:
> On 2015/02/06 23:16:29, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/c2e11810044fe5ff1c1b8588103671925a5b74fe
> > Cr-Commit-Position: refs/heads/master@{#315128}
> 
> Crap. Had to revert: https://codereview.chromium.org/877993004/
> 
> http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4475
> 
> [1054/2776] CXX
>
obj/third_party/mojo_services/src/view_manager/public/cpp/lib/cpp.view_observer.obj
> FAILED: ninja -t msvc -e environment.x86 --
> "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
> /showIncludes /FC
>
@obj/third_party/mojo_services/src/view_manager/public/cpp/lib/cpp.view.obj.rsp
> /c ../../third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc
> /Foobj/third_party/mojo_services/src/view_manager/public/cpp/lib/cpp.view.obj
> /Fdobj/third_party/mojo_services/src/view_manager/public/cpp/cpp_cc.pdb
>
e:\b\build\slave\win8_gn\build\src\third_party\mojo_services\src\view_manager\public\cpp\lib\view.cc(390)
> : error C2248: 'mojo::StructPtr<mojo::ViewportMetrics>::StructPtr' : cannot
> access private member declared in class
'mojo::StructPtr<mojo::ViewportMetrics>'
>        
>
e:\b\build\slave\win8_gn\build\src\third_party\mojo\src\mojo\public\cpp\bindings\struct_ptr.h(31)
> : see declaration of 'mojo::StructPtr<mojo::ViewportMetrics>::StructPtr'
> ninja: build stopped: subcommand failed.
> 
> WAT

https://github.com/domokit/mojo/blob/master/mojo/services/view_manager/public...

ViewportMetricsPtr CreateEmptyViewportMetrics() {
  ViewportMetricsPtr metrics = ViewportMetrics::New();
  metrics->size = Size::New();
  return metrics;
}

that's a return statement in the xvalue position, which should trigger the
rvalue constructor.  So looks like
https://connect.microsoft.com/VisualStudio/feedback/details/1105046/unexpecte...

[viettrungluu, 2015-02-07 00:11:47]

New patchsets have been uploaded after l-g-t-m from jamesr@chromium.org

[viettrungluu, 2015-02-07 00:14:31]

OK, added a .Pass() (with a parallel change in the Mojo repo sent to you).

https://codereview.chromium.org/904103003/diff/1/components/nacl/loader/nacl_...
File components/nacl/loader/nacl_listener.cc (right):

https://codereview.chromium.org/904103003/diff/1/components/nacl/loader/nacl_...
components/nacl/loader/nacl_listener.cc:437:
mojo::embedder::Init(scoped_ptr<mojo::embedder::PlatformSupport>(
On 2015/02/06 22:31:38, jamesr wrote:
> nit: you can just say make_scoped_ptr(new mojo::....), scoped_ptr<T> can be
> rvalue-constructed from scoped_ptr<U> when U is a subclass of T

Done.

[viettrungluu, 2015-02-07 02:13:58]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2015-02-07 02:15:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/904103003/40001

[commit-bot: I haz the power, 2015-02-07 02:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-07 02:15:15]

Transient error: Too many
"tryserver.chromium.win:win8_chromium_gn_dbg,tryserver.chromium.win:win8_chromium_gn_rel"
delimiters in ":".
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[viettrungluu, 2015-02-07 02:22:51]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2015-02-07 02:24:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/904103003/40001

[commit-bot: I haz the power, 2015-02-07 02:26:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-07 02:27:00]

Patchset 3 (id:??) landed as
https://crrev.com/ac702dad4e2b64caacb84c9c5114d4d45456e183
Cr-Commit-Position: refs/heads/master@{#315161}