sync/internal_api/delete_journal.cc - Issue 904083002: Use external ID to match native model nodes during bookmark association.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/delete_journal.cc

Issue 904083002: Use external ID to match native model nodes during bookmark association. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/delete_journal.cc

diff --git a/sync/internal_api/delete_journal.cc b/sync/internal_api/delete_journal.cc

index ebeb5a761268ace27fa7ce2281211dd633109edd..edd10ae888450ed1156be589c936764d4c4b8e22 100644

--- a/sync/internal_api/delete_journal.cc

+++ b/sync/internal_api/delete_journal.cc

@@ -21,6 +21,8 @@ void DeleteJournal::GetBookmarkDeleteJournals(

deleted_entries.begin(); i != deleted_entries.end(); ++i) {

delete_journal_list->push_back(BookmarkDeleteJournal());

delete_journal_list->back().id = (*i)->ref(syncer::syncable::META_HANDLE);

+ delete_journal_list->back().external_id =

+ (*i)->ref(syncer::syncable::LOCAL_EXTERNAL_ID);

delete_journal_list->back().is_folder = (*i)->ref(syncer::syncable::IS_DIR);

const sync_pb::EntitySpecifics& specifics = (*i)->ref(

« no previous file with comments | « chrome/browser/sync/profile_sync_service_bookmark_unittest.cc ('k') | sync/internal_api/public/delete_journal.h » ('j') | no next file with comments »