chrome/browser/sync/glue/bookmark_model_associator.h - Issue 904083002: Use external ID to match native model nodes during bookmark association.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/bookmark_model_associator.h

Issue 904083002: Use external ID to match native model nodes during bookmark association. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/glue/bookmark_model_associator.h

diff --git a/chrome/browser/sync/glue/bookmark_model_associator.h b/chrome/browser/sync/glue/bookmark_model_associator.h

index ad1ff71b43c3eacb0dbdf81ec2fb131ba51210b0..aecdcbf20b7fa662111dba323ea646aa99ba797a 100644

--- a/chrome/browser/sync/glue/bookmark_model_associator.h

+++ b/chrome/browser/sync/glue/bookmark_model_associator.h

@@ -140,10 +140,6 @@ class BookmarkModelAssociator

const bookmarks::BookmarkNode* permanent_node,

const std::string& tag) WARN_UNUSED_RESULT;

- // Compare the properties of a pair of nodes from either domain.

- bool NodesMatch(const bookmarks::BookmarkNode* bookmark,

- const syncer::BaseNode* sync_node) const;

// Check whether bookmark model and sync model are synced by comparing

// their transaction versions.

// Returns a PERSISTENCE_ERROR if a transaction mismatch was detected where

« no previous file with comments | « no previous file | chrome/browser/sync/glue/bookmark_model_associator.cc » ('j') | no next file with comments »