Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 904063002: Loosen the parsing of CDB output in windows; it can start with at least 'ChildEBP' or 'Child-SP', a… (Closed)

Created:
5 years, 10 months ago by sullivan
Modified:
5 years, 10 months ago
Reviewers:
shatch
CC:
chromium-reviews, telemetry-reviews_chromium.org, chrisha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loosen the parsing of CDB output in windows; it can start with at least 'ChildEBP' or 'Child-SP', and the extra output probably isn't much if those are not found. BUG=433966 Committed: https://crrev.com/b16a27610d6bf2c45e6b9dc30d7025497f418e44 Cr-Commit-Position: refs/heads/master@{#315069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sullivan
Chris took a look at the CDB output from that minidump, and our current code ...
5 years, 10 months ago (2015-02-06 16:05:11 UTC) #2
shatch
On 2015/02/06 16:05:11, sullivan wrote: > Chris took a look at the CDB output from ...
5 years, 10 months ago (2015-02-06 16:22:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904063002/1
5 years, 10 months ago (2015-02-06 16:27:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 18:16:33 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 18:17:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b16a27610d6bf2c45e6b9dc30d7025497f418e44
Cr-Commit-Position: refs/heads/master@{#315069}

Powered by Google App Engine
This is Rietveld 408576698