Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 904043002: Revert of Fix inconsistent LengthMode definition for 'textLength' (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fix inconsistent LengthMode definition for 'textLength' (patchset #2 id:20001 of https://codereview.chromium.org/899293002/) Reason for revert: May need some rebaselines of svg/batik/text/textPosition2.svg svg/batik/text/xmlSpace.svg Original issue's description: > Fix inconsistent LengthMode definition for 'textLength' > > The 'textLength' attribute on SVGTextContentElement was defined as > LengthModeOther, while the lengthModeForAnimatedLengthAttribute table > defined as LengthModeWidth. Use the latter in both cases instead. > > BUG=455737 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189637 TBR=ed@opera.com,rhodovan.u-szeged@partner.samsung.com,kouhei@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455737 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
D LayoutTests/svg/animations/animate-textlength-unitmode.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/svg/animations/animate-textlength-unitmode-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
fs
Created Revert of Fix inconsistent LengthMode definition for 'textLength'
5 years, 10 months ago (2015-02-06 15:04:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904043002/1
5 years, 10 months ago (2015-02-06 15:05:08 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 15:05:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189649

Powered by Google App Engine
This is Rietveld 408576698