components/cronet/android/java/src/org/chromium/net/CronetHistogramManager.java - Issue 904033004: [Cronet] Make HistogramManager an abstract class to break dependency on native library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetHistogramManager.java

Issue 904033004: [Cronet] Make HistogramManager an abstract class to break dependency on native library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Helen's comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/histogram_manager.cc ('k') | components/cronet/android/java/src/org/chromium/net/HistogramManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/CronetHistogramManager.java

diff --git a/components/cronet/android/java/src/org/chromium/net/HistogramManager.java b/components/cronet/android/java/src/org/chromium/net/CronetHistogramManager.java

similarity index 84%

copy from components/cronet/android/java/src/org/chromium/net/HistogramManager.java

copy to components/cronet/android/java/src/org/chromium/net/CronetHistogramManager.java

index 498392005142d8a89593c8e8e4ef701a19c07dbc..cb2d8d4797593fc2d271ee024d400a74a48b425b 100644

--- a/components/cronet/android/java/src/org/chromium/net/HistogramManager.java

+++ b/components/cronet/android/java/src/org/chromium/net/CronetHistogramManager.java

@@ -10,8 +10,8 @@ import org.chromium.base.JNINamespace;

* Controls UMA histograms.

@JNINamespace("cronet")

-public final class HistogramManager {

- public HistogramManager() {

+public final class CronetHistogramManager extends HistogramManager {

+ public CronetHistogramManager() {

nativeEnsureInitialized();

}