components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java - Issue 904033004: [Cronet] Make HistogramManager an abstract class to break dependency on native library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java

Issue 904033004: [Cronet] Make HistogramManager an abstract class to break dependency on native library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/HistogramManager.java ('K') | « components/cronet/android/java/src/org/chromium/net/HistogramManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java

diff --git a/components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java b/components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java

index 863d7639169d5bf8dd0bdeaa15dd4f0fde0e472c..34ce1450b5b51f9081b936af8c3ae7d289ea68c2 100644

--- a/components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java

+++ b/components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java

@@ -74,8 +74,6 @@ public class CronetTestActivity extends Activity {

return;

}

- mHistogramManager = new HistogramManager();

String skipInitString = getCommandLineArg(SKIP_FACTORY_INIT_KEY);

if (skipInitString != null) {

return;

@@ -121,6 +119,8 @@ public class CronetTestActivity extends Activity {

mUrlRequestContext = UrlRequestContext.createContext(

getApplicationContext(), config);

+ mHistogramManager = HistogramManager.createHistogramManager();

return HttpUrlRequestFactory.createFactory(getApplicationContext(),

config);

}