Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: components/cronet/android/cronet_loader.cc

Issue 904033004: [Cronet] Make HistogramManager an abstract class to break dependency on native library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Helen's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/base_jni_registrar.h" 5 #include "base/android/base_jni_registrar.h"
6 #include "base/android/jni_android.h" 6 #include "base/android/jni_android.h"
7 #include "base/android/jni_registrar.h" 7 #include "base/android/jni_registrar.h"
8 #include "base/at_exit.h" 8 #include "base/at_exit.h"
9 #include "components/cronet/android/chromium_url_request.h" 9 #include "components/cronet/android/chromium_url_request.h"
10 #include "components/cronet/android/chromium_url_request_context.h" 10 #include "components/cronet/android/chromium_url_request_context.h"
11 #include "components/cronet/android/cronet_histogram_manager.h"
11 #include "components/cronet/android/cronet_url_request.h" 12 #include "components/cronet/android/cronet_url_request.h"
12 #include "components/cronet/android/cronet_url_request_context.h" 13 #include "components/cronet/android/cronet_url_request_context.h"
13 #include "components/cronet/android/histogram_manager.h"
14 #include "net/android/net_jni_registrar.h" 14 #include "net/android/net_jni_registrar.h"
15 #include "url/android/url_jni_registrar.h" 15 #include "url/android/url_jni_registrar.h"
16 #include "url/url_util.h" 16 #include "url/url_util.h"
17 17
18 #if !defined(USE_ICU_ALTERNATIVES_ON_ANDROID) 18 #if !defined(USE_ICU_ALTERNATIVES_ON_ANDROID)
19 #include "base/i18n/icu_util.h" 19 #include "base/i18n/icu_util.h"
20 #endif 20 #endif
21 21
22 namespace cronet { 22 namespace cronet {
23 namespace { 23 namespace {
24 24
25 const base::android::RegistrationMethod kCronetRegisteredMethods[] = { 25 const base::android::RegistrationMethod kCronetRegisteredMethods[] = {
26 {"BaseAndroid", base::android::RegisterJni}, 26 {"BaseAndroid", base::android::RegisterJni},
27 {"ChromiumUrlRequest", cronet::ChromiumUrlRequestRegisterJni}, 27 {"ChromiumUrlRequest", ChromiumUrlRequestRegisterJni},
28 {"ChromiumUrlRequestContext", cronet::ChromiumUrlRequestContextRegisterJni}, 28 {"ChromiumUrlRequestContext", ChromiumUrlRequestContextRegisterJni},
29 {"CronetUrlRequest", cronet::CronetUrlRequestRegisterJni}, 29 {"CronetHistogramManager", CronetHistogramManagerRegisterJni},
30 {"CronetUrlRequestContext", cronet::CronetUrlRequestContextRegisterJni}, 30 {"CronetUrlRequest", CronetUrlRequestRegisterJni},
31 {"HistogramManager", cronet::HistogramManagerRegisterJni}, 31 {"CronetUrlRequestContext", CronetUrlRequestContextRegisterJni},
32 {"NetAndroid", net::android::RegisterJni}, 32 {"NetAndroid", net::android::RegisterJni},
33 {"UrlAndroid", url::android::RegisterJni}, 33 {"UrlAndroid", url::android::RegisterJni},
34 }; 34 };
35 35
36 base::AtExitManager* g_at_exit_manager = NULL; 36 base::AtExitManager* g_at_exit_manager = NULL;
37 37
38 } // namespace 38 } // namespace
39 39
40 // Checks the available version of JNI. Also, caches Java reflection artifacts. 40 // Checks the available version of JNI. Also, caches Java reflection artifacts.
41 jint CronetOnLoad(JavaVM* vm, void* reserved) { 41 jint CronetOnLoad(JavaVM* vm, void* reserved) {
(...skipping 21 matching lines...) Expand all
63 } 63 }
64 64
65 void CronetOnUnLoad(JavaVM* jvm, void* reserved) { 65 void CronetOnUnLoad(JavaVM* jvm, void* reserved) {
66 if (g_at_exit_manager) { 66 if (g_at_exit_manager) {
67 delete g_at_exit_manager; 67 delete g_at_exit_manager;
68 g_at_exit_manager = NULL; 68 g_at_exit_manager = NULL;
69 } 69 }
70 } 70 }
71 71
72 } // namespace cronet 72 } // namespace cronet
OLDNEW
« no previous file with comments | « components/cronet/android/cronet_histogram_manager.cc ('k') | components/cronet/android/histogram_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698