components/cronet/android/cronet_histogram_manager.h - Issue 904033004: [Cronet] Make HistogramManager an abstract class to break dependency on native library.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/android/cronet_histogram_manager.h

Issue 904033004: [Cronet] Make HistogramManager an abstract class to break dependency on native library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/cronet.gypi ('k') | components/cronet/android/cronet_histogram_manager.cc » ('j') | components/cronet/android/java/src/org/chromium/net/HistogramManager.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	xunjieli 2015/02/06 19:05:01 nit: 2015? nit: 2015? mef 2015/02/06 19:28:55 Done. Show quoted text On 2015/02/06 19:05:01, xunjieli wrote: > nit: 2015? Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_CRONET_HISTOGRAM_MANAGER_H_
	xunjieli 2015/02/06 19:05:01 s/COMPONENTS_CRONET_ANDROID_CRONET_CRONET_HISTOGRA s/COMPONENTS_CRONET_ANDROID_CRONET_CRONET_HISTOGRAM_MANAGER_H_/COMPONENTS_CRONET_ANDROID_CRONET_HISTOGRAM_MANAGER_H_ too many cronet :) mef 2015/02/06 19:28:55 Hmm, it means that previously guard didn't match t Show quoted text On 2015/02/06 19:05:01, xunjieli wrote: > s/COMPONENTS_CRONET_ANDROID_CRONET_CRONET_HISTOGRAM_MANAGER_H_/COMPONENTS_CRONET_ANDROID_CRONET_HISTOGRAM_MANAGER_H_ > > too many cronet :) Hmm, it means that previously guard didn't match the file path. Done.
	6 #define COMPONENTS_CRONET_ANDROID_CRONET_CRONET_HISTOGRAM_MANAGER_H_

	7

	8 #include <jni.h>

	9

	10 namespace cronet {

	11

	12 bool CronetHistogramManagerRegisterJni(JNIEnv* env);

	13

	14 } // namespace cronet

	15

	16 #endif // COMPONENTS_CRONET_ANDROID_CRONET_CRONET_HISTOGRAM_MANAGER_H_

OLD	NEW