Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 904013002: Fix OSX IME, Call RVH::SetInputMethodActive() after Attach. (Closed)

Created:
5 years, 10 months ago by lazyboy
Modified:
5 years, 10 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix OSX IME, Call RVH::SetInputMethodActive() after Attach. This broke quite a bit ago when the implicit ordering changed by refactoring. It is unfortunate that we don't have test coverage for mac, and trying to type accent characters (IME) from browsertest didn't work. BUG=450641 Test=On mac, load a chrome app with <webview> that has an input box. Try to type accent chars, e.g. Option+e followed by e. Proper chars should be seen in the input box. Committed: https://crrev.com/8b0b5d0c0e4be272da4233cfad13f2a688f8eec4 Cr-Commit-Position: refs/heads/master@{#315142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
5 years, 10 months ago (2015-02-06 07:53:52 UTC) #2
Fady Samuel
lgtm
5 years, 10 months ago (2015-02-06 08:13:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904013002/1
5 years, 10 months ago (2015-02-06 23:04:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 00:02:20 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 00:02:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b0b5d0c0e4be272da4233cfad13f2a688f8eec4
Cr-Commit-Position: refs/heads/master@{#315142}

Powered by Google App Engine
This is Rietveld 408576698