Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 903993002: rename SkCanvasDrawable to SkDrawable, and make public (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

rename SkCanvasDrawable to SkDrawable, and make public BUG=skia: NOTRY=True ... winbuilder flake Committed: https://skia.googlesource.com/skia/+/4ae9eb7463cf2160723407359608f221c0d5e2a6

Patch Set 1 #

Total comments: 1

Patch Set 2 : add dox for drawDrawable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -219 lines) Patch
M gyp/core.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkCanvas.h View 1 3 chunks +11 lines, -3 lines 0 comments Download
A + include/core/SkDrawable.h View 3 chunks +11 lines, -4 lines 0 comments Download
M include/core/SkPictureRecorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleArc.cpp View 6 chunks +6 lines, -7 lines 0 comments Download
M samplecode/SampleHT.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D src/core/SkCanvasDrawable.h View 1 chunk +0 lines, -69 lines 0 comments Download
D src/core/SkCanvasDrawable.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
A + src/core/SkDrawable.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 7 chunks +17 lines, -17 lines 0 comments Download
M src/core/SkRecordDraw.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRecorder.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/core/SkRecorder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkRecords.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
reed1
lets make it real ptal
5 years, 10 months ago (2015-02-06 05:46:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903993002/1
5 years, 10 months ago (2015-02-06 05:47:07 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-06 05:47:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2318)
5 years, 10 months ago (2015-02-06 05:50:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903993002/1
5 years, 10 months ago (2015-02-06 05:57:03 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-06 05:57:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2322)
5 years, 10 months ago (2015-02-06 06:00:34 UTC) #12
robertphillips
lgtm + dox request https://codereview.chromium.org/903993002/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/903993002/diff/1/include/core/SkCanvas.h#newcode1020 include/core/SkCanvas.h:1020: Needs comment!
5 years, 10 months ago (2015-02-06 14:53:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903993002/20001
5 years, 10 months ago (2015-02-06 15:50:35 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2325)
5 years, 10 months ago (2015-02-06 15:54:17 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903993002/20001
5 years, 10 months ago (2015-02-06 16:02:45 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/4ae9eb7463cf2160723407359608f221c0d5e2a6
5 years, 10 months ago (2015-02-06 16:03:02 UTC) #21
reed1
5 years, 10 months ago (2015-02-06 16:19:10 UTC) #22
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/882853006/ by reed@google.com.

The reason for reverting is: bug in gyp.

Powered by Google App Engine
This is Rietveld 408576698