Issue 903963002: Don't create a pairing registry on platforms that don't provide a delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 903963002: Don't create a pairing registry on platforms that don't provide a delegate. (Closed)

Created:
5 years, 10 months ago by Jamie

Modified:
5 years, 10 months ago

Reviewers:
rmsousa

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't create a pairing registry on platforms that don't provide a delegate. This was broken by https://codereview.chromium.org/834673007. Constructing a PairingRegistry with a null delegate causes pairing to be offered, but if selected, the host process will crash. BUG=455501 Committed: https://crrev.com/dbec99efb805e22b77b5c2d18a2f21e405fbc5cf Cr-Commit-Position: refs/heads/master@{#314969}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	remoting/host/remoting_me2me_host.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903963002/1

5 years, 10 months ago (2015-02-06 03:17:46 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-06 03:50:41 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dbec99efb805e22b77b5c2d18a2f21e405fbc5cf
Cr-Commit-Position: refs/heads/master@{#314969}