Issue 903933006: Add an unnecessary .Pass() in view.cc to try to placate MSVS.

Issue 903933006: Add an unnecessary .Pass() in view.cc to try to placate MSVS. (Closed)

Created:
5 years, 10 months ago by viettrungluu

Modified:
5 years, 10 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add an unnecessary .Pass() in view.cc to try to placate MSVS. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2d5b62d2e24ba76f299b1ea65415274f96f3fb9d

Patch Set 2 : added TODO #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	mojo/services/view_manager/public/cpp/lib/view.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jamesr

https://codereview.chromium.org/903933006/diff/1/mojo/services/view_manager/public/cpp/lib/view.cc File mojo/services/view_manager/public/cpp/lib/view.cc (right): https://codereview.chromium.org/903933006/diff/1/mojo/services/view_manager/public/cpp/lib/view.cc#newcode390 mojo/services/view_manager/public/cpp/lib/view.cc:390: return metrics.Pass(); mind leaving a TODO() to remove this ...

5 years, 10 months ago (2015-02-07 00:37:50 UTC) #2

viettrungluu

On 2015/02/07 00:37:50, jamesr wrote: > https://codereview.chromium.org/903933006/diff/1/mojo/services/view_manager/public/cpp/lib/view.cc > File mojo/services/view_manager/public/cpp/lib/view.cc (right): > > https://codereview.chromium.org/903933006/diff/1/mojo/services/view_manager/public/cpp/lib/view.cc#newcode390 > ...

5 years, 10 months ago (2015-02-07 00:51:07 UTC) #3

viettrungluu

5 years, 10 months ago (2015-02-07 00:53:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2d5b62d2e24ba76f299b1ea65415274f96f3fb9d (presubmit successful).

Expand Messages | Collapse Messages