Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 903833003: Return table headers from the table cell level.

Created:
5 years, 10 months ago by k.czech
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Return table headers for the individual cell Update AXTableCell by adding methods for collecting header objects for the individual cell. Provides also new WebAXObject API. BUG=450255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -1 line) Patch
M Source/modules/accessibility/AXTableCell.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTableCell.cpp View 2 chunks +47 lines, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
M public/web/WebAXObject.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
k.czech
5 years, 10 months ago (2015-02-06 00:12:11 UTC) #2
k.czech
On 2015/02/06 00:12:11, k.czech wrote: Hi Dominic, do you think I could get try bot ...
5 years, 10 months ago (2015-02-06 00:32:49 UTC) #3
k.czech
On 2015/02/06 00:32:49, k.czech wrote: > On 2015/02/06 00:12:11, k.czech wrote: > Hi Dominic, do ...
5 years, 10 months ago (2015-02-10 08:54:54 UTC) #4
k.czech
On 2015/02/06 00:32:49, k.czech wrote: > On 2015/02/06 00:12:11, k.czech wrote: > Hi Dominic, do ...
5 years, 10 months ago (2015-02-10 08:54:54 UTC) #5
dmazzoni
The code looks good, but I'm wondering whether it makes sense to compute this in ...
5 years, 10 months ago (2015-02-13 07:13:34 UTC) #6
k.czech
On 2015/02/13 07:13:34, dmazzoni wrote: > The code looks good, but I'm wondering whether it ...
5 years, 10 months ago (2015-02-13 15:13:56 UTC) #7
dmazzoni
On 2015/02/13 15:13:56, k.czech wrote: > On 2015/02/13 07:13:34, dmazzoni wrote: > > The code ...
5 years, 10 months ago (2015-02-13 16:03:33 UTC) #8
k.czech
5 years, 10 months ago (2015-02-13 16:15:31 UTC) #9
On 2015/02/13 16:03:33, dmazzoni wrote:
> On 2015/02/13 15:13:56, k.czech wrote:
> > On 2015/02/13 07:13:34, dmazzoni wrote:
> > > The code looks good, but I'm wondering whether it makes sense to compute
> this
> > in
> > > Blink. With the information we already have from Blink, could this be
> > > implemented just as easily on the Chromium side?
> > > 
> > > Anything we compute in Blink we have to compute for every cell, whether we
> > need
> > > it or not.
> > Basically in terms of the row headers we only compute left hand side cells
for
> > one particular row. Column headers are calculated the same way, we only
> operate
> > on a column direction top-bottom. This way we will find all the headers
> > (row/column) if there are any for one exact cell.
> > 
> > > 
> > > If we defer to the Chromium browser side, we can wait until, e.g. a screen
> > > reader actually moves focus to a cell and only compute this stuff on
demand.
> > > Does that make sense?
> > This sounds very reasonable
> > > 
> > > For example, BrowserAccessibilityWin::get_columnHeaderCells already tries
to
> > > implement this. Maybe it has a bug - and if so we should fix it - but
would
> it
> > > be possible to compute there?
> > I will check this. Does it only go for Win platform ?
> 
> That's currently implemented as a Win platform function. We can share code
with
> other platforms if they have similar requirements.

I'm wondering whether you could request a try-bot access and bug-editing
permissions for me ?

Powered by Google App Engine
This is Rietveld 408576698